[HUDI-6645] Relax the restriction for Spark MDT rollback#9364
Closed
xuzifu666 wants to merge 4 commits intoapache:masterfrom
Closed
[HUDI-6645] Relax the restriction for Spark MDT rollback#9364xuzifu666 wants to merge 4 commits intoapache:masterfrom
xuzifu666 wants to merge 4 commits intoapache:masterfrom
Conversation
Member
Author
|
cc @danny0405 have a review plz |
danny0405
added
engine:spark
Collaborator
yihua
reviewed
Aug 4, 2023
| } | ||
| } | ||
|
|
||
| protected void validateRollback( |
Contributor
There was a problem hiding this comment.
Why should this be relaxed? Does not look safe for Spark.
Member
Author
There was a problem hiding this comment.
this change need for compation with spark , otherwise would report error @yihua
Contributor
There was a problem hiding this comment.
Why should this be relaxed? Does not look safe for Spark.
It should be safe now, because the MDT log reader can filter out invalid commits based on DT timeline, we need to do this, because Flink has relax the compaction now, if people uses Spark to write into Flink table, then the error throws.
Another choice is to disable the MDT for Flink again, I don't think MDT is production ready for long running MOR job.
4 tasks
codope
added
priority:critical
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Logs
Describe context and summary for this change. Highlight if any code was copied.
none
Impact
Describe any public API or user-facing feature change or any performance impact.
Relax the restriction for Spark MDT rollback
Risk level (write none, low medium or high below)
If medium or high, explain what verification was done to mitigate the risks.
none
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change
ticket number here and follow the instruction to make
changes to the website.
Contributor's checklist