[HUDI-6652] Implement basePath-level synchronization in runHoodieMetaSync#9374
Merged
codope merged 1 commit intoapache:masterfrom Aug 6, 2023
Merged
[HUDI-6652] Implement basePath-level synchronization in runHoodieMetaSync#9374codope merged 1 commit intoapache:masterfrom
codope merged 1 commit intoapache:masterfrom
Conversation
codope
added
component:catalog-sync
nsivabalan
approved these changes
Aug 5, 2023
amrishlal
approved these changes
Aug 5, 2023
| } | ||
|
|
||
| // Get or create a lock for the specific table | ||
| Lock tableLock = TABLE_LOCKS.computeIfAbsent(targetBasePath, k -> new ReentrantLock()); |
Contributor
There was a problem hiding this comment.
What are your thoughts on keying off of the table base path and the syncToolClassName to allow concurrent updates to multiple meta syncs?
Member
Author
There was a problem hiding this comment.
I noticed that for the same table different sync tools run one after the other, so did not see the need to concat tool class to the key. In future, if we plan to run everything concurrently, we can add tool class the the key.
Contributor
There was a problem hiding this comment.
yeah, we can always extend it with more sophisticated requests.
danny0405
approved these changes
Aug 6, 2023
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Logs
This PR introduces a targeted synchronization mechanism based on the
targetBasePathin therunHoodieMetaSyncmethod. The previous class-level synchronization has been replaced with finer-grained locking, allowing concurrent processing for different base paths. Added a unti test to check two syncs can run concurrently if it's different base paths.Impact
Meta sync wouldn't block for multi table deltastreamer.
Risk level (write none, low medium or high below)
low
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change
ticket number here and follow the instruction to make
changes to the website.
Contributor's checklist