Skip to content

[HUDI-6654] Add new log block header type to store record positions#9376

Merged
codope merged 2 commits intoapache:masterfrom
yihua:HUDI-6654-encode-positions
Aug 7, 2023
Merged

[HUDI-6654] Add new log block header type to store record positions#9376
codope merged 2 commits intoapache:masterfrom
yihua:HUDI-6654-encode-positions

Conversation

@yihua
Copy link
Contributor

@yihua yihua commented Aug 6, 2023

Change Logs

Add new log block header type to store record positions.

Impact

This is a log format change.

Risk level (write none, low medium or high below)

medium

Documentation Update

Describe any necessary documentation update if there is any new feature, config, or user-facing change

  • The config description must be updated if new configs are added or the default value of the configs are changed
  • Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
    ticket number here and follow the instruction to make
    changes to the website.

Contributor's checklist

  • Read through contributor's guide
  • Change Logs and Impact were stated clearly
  • Adequate tests were added if applicable
  • CI passed

@yihua yihua added priority:blocker Production down; release blocker release-0.14.0 issue:format-change File format changes labels Aug 6, 2023
@vinothchandar
Copy link
Member

@yihua please also keep the tech specs doc upto date, once this lands.

Are deferring including it in bundles till later? Including it earlier would help 0.14.0 readers read it when written from 0.14.1?

@nsivabalan
Copy link
Contributor

@yihua : can you update PR desc

Copy link
Contributor

@nsivabalan nsivabalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. there is no change in log block or log format version is it? we did the bump in previous patch when we did the delete key serialization right. Guess that should suffice

@nsivabalan
Copy link
Contributor

Looks like there are some CI failures. can you follow up.

@hudi-bot
Copy link
Collaborator

hudi-bot commented Aug 7, 2023

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

@codope codope merged commit a19e25b into apache:master Aug 7, 2023
@yihua
Copy link
Contributor Author

yihua commented Aug 7, 2023

CI passes:
Screenshot 2023-08-07 at 10 37 21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

issue:format-change File format changes priority:blocker Production down; release blocker release-0.14.0

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

6 participants