Skip to content

[HUDI-6668] CTAS should not clear existing hoodie table path#9393

Merged
yihua merged 1 commit intoapache:masterfrom
wecharyu:HUDI-6668
Aug 8, 2023
Merged

[HUDI-6668] CTAS should not clear existing hoodie table path#9393
yihua merged 1 commit intoapache:masterfrom
wecharyu:HUDI-6668

Conversation

@wecharyu
Copy link
Copy Markdown
Contributor

@wecharyu wecharyu commented Aug 8, 2023

Change Logs

Currently Hudi will clear table path if there is any exception in CTAS command:

} catch {
case e: Throwable => // failed to insert data, clear table path
clearTablePath(tablePath, hadoopConf)
throw e
}

It may mistakenly delete the path belongs to another hudi table, we need a check before the clear.

Impact

CTAS will not clear the table path which is not generated by it any more.

Risk level (write none, low medium or high below)

low

Documentation Update

Describe any necessary documentation update if there is any new feature, config, or user-facing change

  • The config description must be updated if new configs are added or the default value of the configs are changed
  • Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
    ticket number here and follow the instruction to make
    changes to the website.

Contributor's checklist

  • Read through contributor's guide
  • Change Logs and Impact were stated clearly
  • Adequate tests were added if applicable
  • CI passed

@hudi-bot
Copy link
Copy Markdown
Collaborator

hudi-bot commented Aug 8, 2023

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

@yihua yihua merged commit 92e9f73 into apache:master Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants