[HUDI-6668] CTAS should not clear existing hoodie table path#9393
Merged
yihua merged 1 commit intoapache:masterfrom Aug 8, 2023
Merged
[HUDI-6668] CTAS should not clear existing hoodie table path#9393yihua merged 1 commit intoapache:masterfrom
yihua merged 1 commit intoapache:masterfrom
Conversation
danny0405
approved these changes
Aug 8, 2023
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Logs
Currently Hudi will clear table path if there is any exception in CTAS command:
hudi/hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/spark/sql/hudi/command/CreateHoodieTableAsSelectCommand.scala
Lines 117 to 121 in 7102e0f
It may mistakenly delete the path belongs to another hudi table, we need a check before the clear.
Impact
CTAS will not clear the table path which is not generated by it any more.
Risk level (write none, low medium or high below)
low
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change
ticket number here and follow the instruction to make
changes to the website.
Contributor's checklist