[HUDI-6680] - Fixing the info log to fetch column value by name instead of index#9421
Merged
danny0405 merged 1 commit intoapache:masterfrom Aug 11, 2023
Merged
Conversation
lokesh-lingarajan-0310
changed the title
yihua
approved these changes
Aug 10, 2023
| col(queryInfo.getOrderColumn()).desc(), col(queryInfo.getKeyColumn()).desc()).first(); | ||
| } | ||
| LOG.info("Processed batch size: " + row.getLong(2) + " bytes"); | ||
| LOG.info("Processed batch size: " + row.get(row.fieldIndex(CUMULATIVE_COLUMN_NAME)) + " bytes"); |
Contributor
There was a problem hiding this comment.
I think the logic is correct before. Just that we should not hard code the column position.
Contributor
Author
There was a problem hiding this comment.
we hit class cast exception in some cases where spark inferred this field as double
Collaborator
danny0405
approved these changes
Aug 11, 2023
prashantwason
pushed a commit
that referenced
this pull request
Aug 18, 2023
… of index (#9421) Co-authored-by: Lokesh Lingarajan <lokeshlingarajan@Lokeshs-MacBook-Pro.local>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Logs
Fixing the log statement to fetch column value by name instead of index. We found spark sometimes infers the cumulative column as double and hence results in class cast exception.
Impact
low
Risk level (write none, low medium or high below)
low
Contributor's checklist