Skip to content

[MINOR] Close record readers in TestHoodieReaderWriterBase after use during tests#9504

Merged
yihua merged 4 commits intoapache:masterfrom
xuzifu666:fix_testcase
Sep 15, 2023
Merged

[MINOR] Close record readers in TestHoodieReaderWriterBase after use during tests#9504
yihua merged 4 commits intoapache:masterfrom
xuzifu666:fix_testcase

Conversation

@xuzifu666
Copy link
Member

Change Logs

Close record readers in TestHoodieReaderWriterBase after use during tests

Impact

none

Risk level (write none, low medium or high below)

If medium or high, explain what verification was done to mitigate the risks.

Documentation Update

Describe any necessary documentation update if there is any new feature, config, or user-facing change

  • The config description must be updated if new configs are added or the default value of the configs are changed
  • Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
    ticket number here and follow the instruction to make
    changes to the website.

Contributor's checklist

  • Read through contributor's guide
  • Change Logs and Impact were stated clearly
  • Adequate tests were added if applicable
  • CI passed

@xuzifu666
Copy link
Member Author

@danny0405 during test,these reader did not close reader,so fix it

@xuzifu666 xuzifu666 closed this Aug 23, 2023
@xuzifu666 xuzifu666 reopened this Aug 23, 2023
@xuzifu666
Copy link
Member Author

@hudi-bot run azure

@yihua
Copy link
Contributor

yihua commented Sep 14, 2023

Rebased on the latest master to fix CI failure.

@hudi-bot
Copy link
Collaborator

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

@yihua yihua merged commit ead5171 into apache:master Sep 15, 2023
nsivabalan pushed a commit that referenced this pull request Nov 21, 2023
…during tests (#9504)

Co-authored-by: xuyu <11161569@vivo.com>
Co-authored-by: Y Ethan Guo <ethan.guoyihua@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants