[HUDI-6739] Skip checking Active Timeline to improve performance for multiple streaming writers#9510
Closed
ad1happy2go wants to merge 1 commit intoapache:masterfrom
Closed
[HUDI-6739] Skip checking Active Timeline to improve performance for multiple streaming writers#9510ad1happy2go wants to merge 1 commit intoapache:masterfrom
ad1happy2go wants to merge 1 commit intoapache:masterfrom
Conversation
ad1happy2go
changed the title
Collaborator
yihua
reviewed
Aug 25, 2023
Comment on lines
+321
to
+322
| if(incomingBatchId == 0) { | ||
| false |
Contributor
There was a problem hiding this comment.
The batch 0 may have already been processed so the last checkpoint still needs to be read. Correct?
Collaborator
Author
There was a problem hiding this comment.
Yes, I agree @yihua . Thanks. Closing this PR then without committing. @nsivabalan Let me know if any concerns.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Logs
Improved the logic for Fixing checkpoint management for multiple streaming writers, so that it dont check the active timeline if offset is 0 as that will mean it is a new writer.
Impact
none
Risk level (write none, low medium or high below)
low
Documentation Update
none
Contributor's checklist