[HUDI-6808] SkipCompaction Config should not affect the stream read of the cow table#9584
Merged
danny0405 merged 1 commit intoapache:masterfrom Sep 4, 2023
Merged
Conversation
danny0405
reviewed
Aug 31, 2023
| public HoodieTimeline filterInstantsAsPerUserConfigs(HoodieTimeline timeline, HoodieTableType tableType) { | ||
| final HoodieTimeline oriTimeline = timeline; | ||
| if (this.skipCompaction) { | ||
| if (tableType.equals(HoodieTableType.MERGE_ON_READ) & this.skipCompaction) { |
Contributor
There was a problem hiding this comment.
Another choice is to resolve the table type with OptionsResolver and the this.conf.
Contributor
Author
There was a problem hiding this comment.
Adjusted to use OptionsResolver.
zhuanshenbsj1
force-pushed
the
HUDI-6808
branch
2 times, most recently
from
65e83e4 to
cd3a969
Compare
danny0405
reviewed
Sep 1, 2023
| public HoodieTimeline filterInstantsAsPerUserConfigs(HoodieTimeline timeline, HoodieTableType tableType) { | ||
| final HoodieTimeline oriTimeline = timeline; | ||
| if (this.skipCompaction) { | ||
| if (OptionsResolver.isMorTable(this.conf) & this.skipCompaction) { |
Contributor
There was a problem hiding this comment.
There is no need to pass around the HoodieTableType now.
Contributor
Author
There was a problem hiding this comment.
Removed the para HoodieTableType.
zhuanshenbsj1
force-pushed
the
HUDI-6808
branch
from
cd3a969 to
cba1cba
Compare
danny0405
approved these changes
Sep 1, 2023
Collaborator
nsivabalan
added
priority:blocker
prashantwason
pushed a commit
that referenced
this pull request
Sep 13, 2023
…f the cow table (#9584)
leosanqing
pushed a commit
to leosanqing/hudi
that referenced
this pull request
Sep 13, 2023
TheR1sing3un
pushed a commit
to TheR1sing3un/hudi
that referenced
this pull request
Feb 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Logs
The same action type(commit) is used after the completion of mor-compaction and cow-commit. If skipcompaction is configured, it will cause the stream read to skip the normal commit when reading the cow table. SkipCompaction Config should not affect the stream read of the cow table .
Impact
Describe any public API or user-facing feature change or any performance impact.
Risk level (write none, low medium or high below)
If medium or high, explain what verification was done to mitigate the risks.
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change
ticket number here and follow the instruction to make
changes to the website.
Contributor's checklist