Skip to content

[MINOR] Avoiding to ingest update records to RLI#9675

Merged
nsivabalan merged 1 commit intoapache:masterfrom
nsivabalan:rli_AvoidUpdates
Sep 12, 2023
Merged

[MINOR] Avoiding to ingest update records to RLI#9675
nsivabalan merged 1 commit intoapache:masterfrom
nsivabalan:rli_AvoidUpdates

Conversation

@nsivabalan
Copy link
Contributor

Change Logs

Optimize RLI to not ingest records for updates from data table.

Impact

Optimize RLI to not ingest records for updates from data table.

Risk level (write none, low medium or high below)

low

Documentation Update

Describe any necessary documentation update if there is any new feature, config, or user-facing change

  • The config description must be updated if new configs are added or the default value of the configs are changed
  • Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
    ticket number here and follow the instruction to make
    changes to the website.

Contributor's checklist

  • Read through contributor's guide
  • Change Logs and Impact were stated clearly
  • Adequate tests were added if applicable
  • CI passed

}
// for updates, we can skip updating RLI partition in MDT
} else {
hoodieRecord = HoodieMetadataPayload.createRecordIndexUpdate(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so newLocation is present but currentLocation is not.. this should happen only with append handle right and no other place? I assume you have already checked that

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope. even w/ merge handle. essentially, if a record is an update record both locations will be set. if not, only new location will be set.

@nsivabalan nsivabalan added priority:blocker Production down; release blocker release-0.14.0 labels Sep 11, 2023
@nsivabalan
Copy link
Contributor Author

@hudi-bot run azure

1 similar comment
@nsivabalan
Copy link
Contributor Author

@hudi-bot run azure

@hudi-bot
Copy link
Collaborator

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

@nsivabalan
Copy link
Contributor Author

image

@nsivabalan nsivabalan merged commit f0a73bd into apache:master Sep 12, 2023
leosanqing pushed a commit to leosanqing/hudi that referenced this pull request Sep 13, 2023
TheR1sing3un pushed a commit to TheR1sing3un/hudi that referenced this pull request Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority:blocker Production down; release blocker release-0.14.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants