Skip to content

[HUDI-6893] Copy the trino bundle to override the one in the image#9781

Merged
yihua merged 1 commit intoapache:masterfrom
codope:fix-trino-bundle
Sep 26, 2023
Merged

[HUDI-6893] Copy the trino bundle to override the one in the image#9781
yihua merged 1 commit intoapache:masterfrom
codope:fix-trino-bundle

Conversation

@codope
Copy link
Member

@codope codope commented Sep 25, 2023

Change Logs

Copy the trino bundle at run time so that locally built bundle overrides the one that is present in the image.

Impact

Docker-based integ test to use snapshot version of hudi-trino-bundle.

Risk level (write none, low medium or high below)

none

Documentation Update

Describe any necessary documentation update if there is any new feature, config, or user-facing change

  • The config description must be updated if new configs are added or the default value of the configs are changed
  • Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
    ticket number here and follow the instruction to make
    changes to the website.

Contributor's checklist

  • Read through contributor's guide
  • Change Logs and Impact were stated clearly
  • Adequate tests were added if applicable
  • CI passed

@boneanxs
Copy link
Contributor

@codope Thanks for the fix!

Apply the fix and rebuild trinobase and trinocoordinator.
Start the containers with local build image:
docker/setup_demo.sh dev

Confirmed that the new jar are used:

root@trino-coordinator-1:/usr/local/trino-server-368# md5sum plugin/hive/hudi-trino-bundle.jar
63525185e836e22d0012ab6e72a3089a  plugin/hive/hudi-trino-bundle.jar

(base) hui.an@mac hudi-community % md5 docker/hoodie/hadoop/trinobase/target/hudi-trino-bundle.jar
MD5 (docker/hoodie/hadoop/trinobase/target/hudi-trino-bundle.jar) = 63525185e836e22d0012ab6e72a3089a

After I changed the hudi-trino-bundle.jar under docker/hoodie/hadoop/trinobase/target/, and restart the image, the jar can still matched:

root@trino-coordinator-1:/usr/local/trino-server-368# md5sum plugin/hive/hudi-trino-bundle.jar
8abf85f098e69fd1eaa96333392032c7  plugin/hive/hudi-trino-bundle.jar

(base) hui.an@mac hudi-community % md5 docker/hoodie/hadoop/trinobase/target/hudi-trino-bundle.jar
MD5 (docker/hoodie/hadoop/trinobase/target/hudi-trino-bundle.jar) = 8abf85f098e69fd1eaa96333392032c7

@codope
Copy link
Member Author

codope commented Sep 26, 2023

Thanks @boneanxs. I was missing the dev option while running setup_demo.sh. I will update the image in the dockerhub and land this PR soon. Then you can rebase your PR.

@apache apache deleted a comment from hudi-bot Sep 26, 2023
@hudi-bot
Copy link
Collaborator

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

Copy link
Contributor

@yihua yihua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yihua yihua merged commit 30146d6 into apache:master Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants