fix(rag): rag api critical bug & rename some params#114
Merged
imbajin merged 9 commits intoapache:mainfrom Nov 18, 2024
returnToInnocence:20241114-fixRagApiLog
Merged
fix(rag): rag api critical bug & rename some params#114imbajin merged 9 commits intoapache:mainfrom returnToInnocence:20241114-fixRagApiLog
imbajin merged 9 commits intoapache:mainfrom
returnToInnocence:20241114-fixRagApiLog
Conversation
dosubot
bot
added
size:M
imbajin
reviewed
Nov 16, 2024
Comment on lines
24
to
28
| text: str = "" | ||
| raw_answer: bool = False | ||
| vector_only_answer: bool = False | ||
| graph_only_answer: bool = False | ||
| graph_vector_answer: bool = False |
Collaborator
Author
There was a problem hiding this comment.
My reasons for removing optional:
The purpose of using optional is to make the value support None, but since I have assigned it by default, None will never happen, so the optional is effectively invalid, so it is removed
References:
- Fastapi official documentation (https://fastapi.tiangolo.com/python-types/#using-union-or-optional)
Co-authored-by: imbajin <jin@apache.org>
dosubot
bot
added
size:L
imbajin
approved these changes
Nov 18, 2024
imbajin
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added "Enable api authentication based on ENABLE_LOGIN in
.envfile". (in filehugegraph-llm/src/hugegraph_llm/demo/rag_demo/app.py)Synchronize according to the arguments of the latest rag_answer function. (in other changes files)
remove
Optional, My reasons for removing optional:The purpose of using optional is to make the value support None, but since I have assigned it by default, None will never happen, so the optional is effectively invalid, so it is removed
remove
OptionalReferences: