Skip to content

fix(llm): answer prompt None value effect#116

Merged
imbajin merged 2 commits intoapache:mainfrom
returnToInnocence:20241118-rag-prompt-fix
Nov 19, 2024
Merged

fix(llm): answer prompt None value effect#116
imbajin merged 2 commits intoapache:mainfrom
returnToInnocence:20241118-rag-prompt-fix

Conversation

@returnToInnocence
Copy link
Collaborator

Solve the problem that the final result is not as expected when the answer_prompt in the body parameter of /rag api is None or an empty string

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Nov 18, 2024
@github-actions github-actions bot added the llm label Nov 18, 2024
@dosubot dosubot bot added the bug Something isn't working label Nov 18, 2024
near_neighbor_first: bool = False
custom_priority_info: str = ""
answer_prompt: str = ""
answer_prompt: Optional[str] = None
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: handle it later

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 19, 2024
@imbajin imbajin merged commit 153d7f4 into apache:main Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working lgtm This PR has been approved by a maintainer llm size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants