Merged
Conversation
dosubot
bot
added
the
size:M
imbajin
reviewed
Nov 19, 2024
| graph_user: Optional[str] = "admin" | ||
| graph_pwd: Optional[str] = "xxx" | ||
| graph_space: Optional[str] = None | ||
| enable_prop_limit: Optional[str] = "False" |
Member
There was a problem hiding this comment.
prefer short param name like limit_property
Contributor
Author
There was a problem hiding this comment.
changed to limit_property
| self, | ||
| max_deep: int = 2, | ||
| max_items: int = 30, | ||
| max_v_prop_length: int = 4096, |
Member
There was a problem hiding this comment.
max_v_prop_len or v_prop_len_max
same as edge
Contributor
Author
There was a problem hiding this comment.
changed to max_v_prop_len and max_e_prop_len
imbajin
reviewed
Nov 20, 2024
hugegraph-llm/src/hugegraph_llm/operators/hugegraph_op/graph_rag_query.py
Outdated
Show resolved
Hide resolved
imbajin
reviewed
Nov 20, 2024
| raw_flat_rel)[i - 1]["props"][self._prop_to_match] | ||
|
|
||
| if item["label"] in e_cache: | ||
| if (item['inV'], item['label'], item['outV']) in e_cache: |
Member
There was a problem hiding this comment.
avoid visit params multi times
imbajin
force-pushed
the
limit-property-length
branch
from
b563868 to
a5eca07
Compare
imbajin
force-pushed
the
limit-property-length
branch
from
a5eca07 to
e4e65be
Compare
imbajin
approved these changes
Nov 21, 2024
HJ-Young
pushed a commit
to HJ-Young/incubator-hugegraph-ai
that referenced
this pull request
Nov 26, 2024
- [X] fix edge cache using (inV, label, outV) as key - [X] limit node and edge property length - [X] handle isolate node problem --------- Co-authored-by: imbajin <jin@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.