Skip to content

fix(llm): limit the deps version to handle critical init problems#279

Merged
imbajin merged 2 commits intomainfrom
fix-gradio
Jun 19, 2025
Merged

fix(llm): limit the deps version to handle critical init problems#279
imbajin merged 2 commits intomainfrom
fix-gradio

Conversation

@imbajin
Copy link
Member

@imbajin imbajin commented Jun 19, 2025

Note:

DON'T USE xxx > x.x in python deps management (This would lead to unforeseeable disaster:👿)

refer: gradio-app/gradio#10649 (comment)

@imbajin imbajin requested a review from Copilot June 19, 2025 11:09
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jun 19, 2025
@github-actions github-actions bot added the llm label Jun 19, 2025
@imbajin imbajin requested a review from simon824 June 19, 2025 11:10
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR tightens dependency version specifications in pyproject.toml to avoid unintended upgrades by replacing loose constraints (>, >=) with more restrictive ~= pins and adding an explicit pin for pydantic.

  • Switched tiktoken, gradio, and python-dotenv to ~= constraints
  • Added pydantic~=2.10.6 and fixed trailing comma on hugegraph-python-client
Comments suppressed due to low confidence (2)

hugegraph-llm/pyproject.toml:40

  • [nitpick] Using ~= pins gradio to <5.21.0, which may block safe minor upgrades. Confirm this restriction aligns with expected compatibility requirements.
    "gradio~=5.20.0",

hugegraph-llm/pyproject.toml:59

  • No version constraint is specified for hugegraph-python-client, which can lead to unpredictable breaking changes. It’s recommended to pin it with a ~= specifier.
    "hugegraph-python-client",

@dosubot dosubot bot added bug Something isn't working dependencies Pull requests that update a dependency file labels Jun 19, 2025
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Jun 19, 2025
@imbajin imbajin merged commit 0bf31d2 into main Jun 19, 2025
10 checks passed
@imbajin imbajin deleted the fix-gradio branch June 19, 2025 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working dependencies Pull requests that update a dependency file llm size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants