Skip to content
This repository was archived by the owner on Feb 24, 2026. It is now read-only.

Comments

fix apache revision#114

Merged
javeme merged 2 commits intoapache:masterfrom
z7658329:feat/fix_revision
Nov 4, 2022
Merged

fix apache revision#114
javeme merged 2 commits intoapache:masterfrom
z7658329:feat/fix_revision

Conversation

@z7658329
Copy link
Member

@z7658329 z7658329 commented Nov 4, 2022

fix apache revision

@codecov
Copy link

codecov bot commented Nov 4, 2022

Codecov Report

Merging #114 (d90b444) into master (16602cc) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #114   +/-   ##
=========================================
  Coverage     93.15%   93.15%           
  Complexity       65       65           
=========================================
  Files             9        9           
  Lines           263      263           
  Branches         22       22           
=========================================
  Hits            245      245           
  Misses            8        8           
  Partials         10       10           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@z7658329
Copy link
Member Author

z7658329 commented Nov 4, 2022

the apache stage version, still have some problems:
https://repository.apache.org/content/groups/staging/org/apache/hugegraph/hugegraph-common/1.0.0/hugegraph-common-1.0.0.pom

it will cause hugegraph-client build error:
image

image

i fix this problem in local:
image

image

@z7658329
Copy link
Member Author

z7658329 commented Nov 4, 2022

ut have some error, but test in local is ok
image

@z7658329
Copy link
Member Author

z7658329 commented Nov 4, 2022

@javeme @imbajin
test in local is ok
image

failed in ci, see:
https://github.com/apache/incubator-hugegraph-commons/actions/runs/3390737617/jobs/5635202250

image

is there any thing wrong?

Comment on lines +223 to +225
<groupId>org.codehaus.mojo</groupId>
<artifactId>flatten-maven-plugin</artifactId>
<version>1.2.7</version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any extra cmd do we need?

@javeme javeme merged commit 7347b17 into apache:master Nov 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants