This repository was archived by the owner on Feb 24, 2026. It is now read-only.
Conversation
This comment was marked as off-topic.
This comment was marked as off-topic.
01be0b4 to
94c4121
Compare
Member
Author
|
rebase and merge this PR, and other repo could refer this PR (modify a little comment & param) |
javeme
reviewed
Dec 4, 2022
| # diff generated 'current-dependencies.txt' file with 'known-dependencies.txt' file. | ||
| diff -w -B -U0 <(sort < ${BASE_PATH}/known-dependencies.txt) \ | ||
| <(sort < ${BASE_PATH}/current-dependencies.txt) > ${BASE_PATH}/result.txt | ||
| diff -w -B -U0 <(sort <"${BASE_PATH}"/known-dependencies.txt) \ |
Member
Author
There was a problem hiding this comment.
it's better to not keep space after < or > in the shell script style (avoid < () and file_descriptor > xx error)
but keep the original style is also fine (revert it)
hugegraph-dist/scripts/dependency/regenerate_known_dependencies.sh
Outdated
Show resolved
Hide resolved
94c4121 to
e1f0101
Compare
javeme
approved these changes
Dec 5, 2022
zyxxoo
approved these changes
Dec 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
we could use git command to generate source file directly (and exclude some files by
.gitattr)git archive --format=tar.gz --output=dist/apache-hugegraph-commons/apache-hugegraph-commons-1.0.0-incubating-src.tar.gz --prefix=apache-hugegraph-commons-1.0.0-incubating-src/ release-1.0.0and I try to unify the release steps by one script, it should be test first