This repository was archived by the owner on Feb 24, 2026. It is now read-only.
refact(common): add more construction methods for convenient#132
Merged
javeme merged 2 commits intoapache:masterfrom Jul 19, 2023
Merged
refact(common): add more construction methods for convenient#132javeme merged 2 commits intoapache:masterfrom
javeme merged 2 commits intoapache:masterfrom
Conversation
Member
|
thanks,maybe change the merge branch to master? @VGalaxies all need meet? |
Contributor
All the required ctors are now in place 🎈 |
Codecov Report
@@ Coverage Diff @@
## master #132 +/- ##
=========================================
Coverage 93.15% 93.15%
Complexity 65 65
=========================================
Files 9 9
Lines 263 263
Branches 22 22
=========================================
Hits 245 245
Misses 8 8
Partials 10 10 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
javeme
reviewed
Jul 12, 2023
| EventHub.init(1); | ||
| } | ||
|
|
||
| public EventHub(String name, int threadSize) { |
Contributor
There was a problem hiding this comment.
just let EventHub(String name) call EventHub(name, 1)
| this.content = response.readEntity(String.class); | ||
| } | ||
|
|
||
| public RestResult(int status, String content, MultivaluedMap<String, Object> headers) { |
bc4f46f to
c4d5603
Compare
imbajin
approved these changes
Jul 18, 2023
javeme
approved these changes
Jul 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add some construction methods for more convenient use