Skip to content
This repository was archived by the owner on Feb 24, 2026. It is now read-only.

Comments

refact(common): add more construction methods for convenient#132

Merged
javeme merged 2 commits intoapache:masterfrom
chengxin1374:release-1.0.0
Jul 19, 2023
Merged

refact(common): add more construction methods for convenient#132
javeme merged 2 commits intoapache:masterfrom
chengxin1374:release-1.0.0

Conversation

@chengxin1374
Copy link
Contributor

add some construction methods for more convenient use

@imbajin
Copy link
Member

imbajin commented Jul 11, 2023

thanks,maybe change the merge branch to master?

@VGalaxies all need meet?

@chengxin1374 chengxin1374 changed the base branch from release-1.0.0 to master July 11, 2023 14:30
@VGalaxies
Copy link
Contributor

thanks,maybe change the merge branch to master?

@VGalaxies all need meet?

All the required ctors are now in place 🎈

@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Merging #132 (e5c174a) into master (297e491) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #132   +/-   ##
=========================================
  Coverage     93.15%   93.15%           
  Complexity       65       65           
=========================================
  Files             9        9           
  Lines           263      263           
  Branches         22       22           
=========================================
  Hits            245      245           
  Misses            8        8           
  Partials         10       10           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

imbajin
imbajin previously approved these changes Jul 12, 2023
Copy link
Member

@imbajin imbajin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imbajin imbajin requested a review from zyxxoo July 12, 2023 04:34
@imbajin imbajin changed the title add some construction methods for more convenient use refact(common): add more construction methods for convenient Jul 12, 2023
@imbajin imbajin requested a review from javeme July 12, 2023 05:00
EventHub.init(1);
}

public EventHub(String name, int threadSize) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just let EventHub(String name) call EventHub(name, 1)

this.content = response.readEntity(String.class);
}

public RestResult(int status, String content, MultivaluedMap<String, Object> headers) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

@javeme javeme merged commit c31a536 into apache:master Jul 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants