This repository was archived by the owner on Feb 24, 2026. It is now read-only.
Conversation
Codecov Report
@@ Coverage Diff @@
## master #43 +/- ##
============================================
+ Coverage 80.72% 81.17% +0.45%
- Complexity 620 650 +30
============================================
Files 55 56 +1
Lines 1914 1981 +67
Branches 281 291 +10
============================================
+ Hits 1545 1608 +63
+ Misses 253 249 -4
- Partials 116 124 +8
Continue to review full report at Codecov.
|
Change-Id: I3709d96fd2114fa782d6f28f8853b32d65fbd22b
Change-Id: If59870fb4f281f40af5bfbe3858c443108d4180e
Change-Id: I1add942c011cfc1b6faf998d94901fc2d8723169
Change-Id: I3ed1e3431f3d9b4ba6f66479fd557808c4c28ddc
Change-Id: I12698bc3aa17b8b9cd71fe6646a483a1c3dedbc9
javeme
force-pushed
the
fix-iter-close
branch
from
0cf63cf to
9964a8f
Compare
Linary
suggested changes
Jan 7, 2020
| // Call next() without hasNext() | ||
| Assert.assertEquals(1, results.next()); | ||
|
|
||
| results = new BatchMapperIterator<>(1, DATA3.iterator(), MAPPER); |
Contributor
There was a problem hiding this comment.
add a test with batch size 2
| } | ||
|
|
||
| @Test | ||
| public void testMapperTHenReturn2X() { |
zhoney
suggested changes
Jan 7, 2020
| return false; | ||
| } | ||
|
|
||
| protected final void resetResults() { |
| return false; | ||
| } | ||
|
|
||
| protected final void resetResults() { |
Change-Id: I5c6fe38612ead857ab25d8ebabf2f9775b4ac3da
Linary
approved these changes
Jan 8, 2020
zhoney
approved these changes
Jan 8, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change-Id: I3709d96fd2114fa782d6f28f8853b32d65fbd22b