Skip to content
This repository was archived by the owner on Feb 24, 2026. It is now read-only.

Comments

fix BatchMapperIterator stopped when fetched none in the middle batch#64

Merged
Linary merged 2 commits intomasterfrom
fix-BatchMapperIterator
Feb 25, 2021
Merged

fix BatchMapperIterator stopped when fetched none in the middle batch#64
Linary merged 2 commits intomasterfrom
fix-BatchMapperIterator

Conversation

@javeme
Copy link
Contributor

@javeme javeme commented Feb 25, 2021

Change-Id: I275cf41016829d2594f728c89d66526a7f9d4374

Change-Id: I275cf41016829d2594f728c89d66526a7f9d4374
@codecov
Copy link

codecov bot commented Feb 25, 2021

Codecov Report

Merging #64 (46c9e3a) into master (c80f959) will increase coverage by 0.09%.
The diff coverage is 85.71%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #64      +/-   ##
============================================
+ Coverage     84.73%   84.83%   +0.09%     
- Complexity      756      759       +3     
============================================
  Files            59       59              
  Lines          2182     2183       +1     
  Branches        321      321              
============================================
+ Hits           1849     1852       +3     
- Misses          189      190       +1     
+ Partials        144      141       -3     
Impacted Files Coverage Δ Complexity Δ
.../baidu/hugegraph/iterator/BatchMapperIterator.java 82.92% <80.00%> (+2.92%) 17.00 <0.00> (+1.00)
.../com/baidu/hugegraph/iterator/WrappedIterator.java 79.41% <100.00%> (ø) 13.00 <0.00> (ø)
...c/main/java/com/baidu/hugegraph/util/DateUtil.java 76.00% <0.00%> (-8.00%) 9.00% <0.00%> (-1.00%)
.../main/java/com/baidu/hugegraph/event/EventHub.java 81.94% <0.00%> (+1.38%) 27.00% <0.00%> (+1.00%)
...n/java/com/baidu/hugegraph/concurrent/KeyLock.java 80.39% <0.00%> (+1.96%) 26.00% <0.00%> (+1.00%)
.../main/java/com/baidu/hugegraph/perf/Stopwatch.java 87.75% <0.00%> (+2.04%) 21.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c80f959...46c9e3a. Read the comment docs.

List<T> list = this.nextBatch();
if (!list.isEmpty()) {
List<T> batch = this.nextBatch();
if (!batch.isEmpty()) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove if, remains while only

Change-Id: I658d8e95a68c8a9494efa98e88f350cf6d65b021
@Linary Linary merged commit cde7763 into master Feb 25, 2021
@Linary Linary deleted the fix-BatchMapperIterator branch February 25, 2021 12:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants