This repository was archived by the owner on Feb 24, 2026. It is now read-only.
Add Class.class as an accept data type in TypedOption#65
Merged
houzhizhen merged 3 commits intomasterfrom Mar 7, 2021
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #65 +/- ##
============================================
+ Coverage 84.80% 84.83% +0.02%
- Complexity 767 768 +1
============================================
Files 60 60
Lines 2205 2209 +4
Branches 324 325 +1
============================================
+ Hits 1870 1874 +4
Misses 191 191
Partials 144 144
Continue to review full report at Codecov.
|
javeme
reviewed
Mar 3, 2021
| return Class.forName(value); | ||
| } catch (ClassNotFoundException e) { | ||
| throw new RuntimeException(String.format( | ||
| "Failed to convert String to Class '%s'", value), e); |
Contributor
There was a problem hiding this comment.
"Failed to parse Class from String '%s'"
Contributor
|
ci error: |
zhoney
previously approved these changes
Mar 4, 2021
javeme
previously approved these changes
Mar 4, 2021
javeme
approved these changes
Mar 7, 2021
houzhizhen
approved these changes
Mar 7, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.