This repository was archived by the owner on Feb 24, 2026. It is now read-only.
Conversation
* add rpc framework based on sofa-rpc * allowed to start server or client separately * add destroy() method for rpc client * complete the supplement of test cases * remove sleep in destroy-server and improve comments of test block * add fanout exception test case * travis use oraclejdk8 * fix log4j config and remove test/resources from pom to avoid including log4j2.xml in tar Co-authored-by: Jermy Li <lizhangmei@baidu.com> Co-authored-by: xuliguov5 <xuliguo@baidu.com>
* add rpc.server_adaptive_port option * use bolt v1.6.2 instead of v1.5.6 to get RemotingServer.port()
1. root pom.xml, license, checkstyle, ci,
javeme
reviewed
Dec 1, 2021
Codecov Report
@@ Coverage Diff @@
## master #84 +/- ##
============================================
+ Coverage 89.03% 93.12% +4.09%
+ Complexity 943 65 -878
============================================
Files 63 9 -54
Lines 2744 262 -2482
Branches 399 22 -377
============================================
- Hits 2443 244 -2199
+ Misses 154 8 -146
+ Partials 147 10 -137
Continue to review full report at Codecov.
|
Member
Author
|
after review & CI pass, separate this pr into 2 |
javeme
reviewed
Dec 2, 2021
| <developer> | ||
| <name>liningrui</name> | ||
| <email>liningrui@vip.qq.com</email> | ||
| </developer> |
Member
Author
There was a problem hiding this comment.
it's optional & maybe do it in a separate pr (if need)
javeme
previously approved these changes
Dec 3, 2021
zhoney
approved these changes
Dec 7, 2021
javeme
approved these changes
Dec 7, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for apache need, after this pr, we will:
pom.xml&READMEin root dir