Conversation
|
CLA Assistant Lite bot Good! All Contributors have signed the CLA. |
| public void file(String path) { | ||
| this.path = path; | ||
| } | ||
|
|
There was a problem hiding this comment.
can move loadConfigFile(String path) to line 170
hugegraph-common/src/main/java/com/baidu/hugegraph/config/HugeConfig.java
Outdated
Show resolved
Hide resolved
| private final String path; | ||
| private String path; | ||
|
|
||
| public HugeConfig(Configuration config) { |
There was a problem hiding this comment.
can extract file from Configuration as possible?
There was a problem hiding this comment.
I dont have idea, the ProperityConfiguration have a private field 'Location', but not get method
There was a problem hiding this comment.
For the convenience of users, we can try to use a trick way like Whitebox
hugegraph-common/src/main/java/com/baidu/hugegraph/config/HugeConfig.java
Show resolved
Hide resolved
| private final String path; | ||
| private String path; | ||
|
|
||
| public HugeConfig(Configuration config) { |
There was a problem hiding this comment.
For the convenience of users, we can try to use a trick way like Whitebox
|
I have read the CLA Document and I hereby sign the CLA |
javeme
changed the title
hugegraph-common/src/main/java/com/baidu/hugegraph/config/HugeConfig.java
Outdated
Show resolved
Hide resolved
hugegraph-common/src/main/java/com/baidu/hugegraph/config/HugeConfig.java
Show resolved
Hide resolved
|
ci error: Tests run: 334, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 56.455 sec <<< FAILURE!
testGetCommonVersion(com.baidu.hugegraph.unit.version.VersionTest) Time elapsed: 1.698 sec <<< FAILURE!
org.junit.ComparisonFailure: expected:<2.1.[1]> but was:<2.1.[0]>
at org.junit.Assert.assertEquals(Assert.java:115)
at org.junit.Assert.assertEquals(Assert.java:144)
at com.baidu.hugegraph.unit.version.VersionTest.testGetCommonVersion(VersionTest.java:36) |
Codecov Report
@@ Coverage Diff @@
## master #93 +/- ##
=========================================
Coverage 93.15% 93.15%
Complexity 65 65
=========================================
Files 9 9
Lines 263 263
Branches 22 22
=========================================
Hits 245 245
Misses 8 8
Partials 10 10 Continue to review full report at Codecov.
|
3 participants
No description provided.