Skip to content

fix(k8s): modify inconsistent apiGroups#270

Merged
coderzc merged 1 commit intoapache:masterfrom
Radeity:fix-apigroups
Oct 20, 2023
Merged

fix(k8s): modify inconsistent apiGroups#270
coderzc merged 1 commit intoapache:masterfrom
Radeity:fix-apigroups

Conversation

@Radeity
Copy link
Member

@Radeity Radeity commented Oct 17, 2023

Purpose of the PR

io.fabric8.kubernetes.client.KubernetesClientException: Failure executing: GET at: https://10.96.0.1/apis/operator.hugegraph.apache.org/v1/hugegraphcomputerjobs. Message: Forbidden!Configured service account doesn't have access. Service account may have been revoked. hugegraphcomputerjobs.operator.hugegraph.apache.org is forbidden: User "system:serviceaccount:hugegraph-computer-operator-system:hugegraph-computer-operator-controller-manager" cannot list resource "hugegraphcomputerjobs" in API group "operator.hugegraph.apache.org" at the cluster scope.

Main Changes

  • Modify KubeBuilder comment and generate role.yaml with correct apiGroups.

Verifying these changes

  • Trivial rework / code cleanup without any test coverage. (No Need)
  • Already covered by existing tests, such as (please modify tests here).
  • Need tests and can be verified as follows.

Does this PR potentially affect the following parts?

  • Nope
  • Dependencies (add/update license info)
  • Modify configurations
  • The public API
  • Other affects (typed here)

Documentation Status

  • Doc - TODO
  • Doc - Done
  • Doc - No Need

@Radeity
Copy link
Member Author

Radeity commented Oct 17, 2023

cc @coderzc

@Radeity
Copy link
Member Author

Radeity commented Oct 19, 2023

Hi @coderzc , CI meets TransportException, plz help rerun CI :D

@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

Merging #270 (ede614f) into master (a21a191) will increase coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #270   +/-   ##
=========================================
  Coverage     85.82%   85.83%           
- Complexity     3233     3234    +1     
=========================================
  Files           344      344           
  Lines         12124    12124           
  Branches       1092     1092           
=========================================
+ Hits          10406    10407    +1     
- Misses         1193     1194    +1     
+ Partials        525      523    -2     

see 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@coderzc coderzc merged commit 479e1a4 into apache:master Oct 20, 2023
@Radeity Radeity deleted the fix-apigroups branch October 20, 2023 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants