Skip to content

Improve: Passing workerId to WorkerStat & Skip wait worker close if master executes failed#292

Merged
simon824 merged 2 commits intomasterfrom
improve_worker_id
Dec 6, 2023
Merged

Improve: Passing workerId to WorkerStat & Skip wait worker close if master executes failed#292
simon824 merged 2 commits intomasterfrom
improve_worker_id

Conversation

@coderzc
Copy link
Member

@coderzc coderzc commented Dec 6, 2023

Main Changes

  • Passing workerId to WorkerStat.
  • If master executes failed, skip wait worker close when close master.
image

Verifying these changes

  • Trivial rework / code cleanup without any test coverage. (No Need)
  • Already covered by existing tests, such as (please modify tests here).
  • Need tests and can be verified as follows.

Does this PR potentially affect the following parts?

  • Nope
  • Dependencies (add/update license info)
  • Modify configurations
  • The public API
  • Other affects (typed here)

Documentation Status

  • Doc - TODO
  • Doc - Done
  • Doc - No Need

@coderzc coderzc changed the title Improve: Passing workerId to WorkerStat & Skip wait worker close when master executes failed Improve: Passing workerId to WorkerStat & Skip wait worker close if master executes failed Dec 6, 2023
@imbajin
Copy link
Member

imbajin commented Dec 6, 2023

CI error refer here: adf4c43#diff-ddf622d3d17b1ad33510d45f00504beb293ebefe76b3977511ae7033676628c0
image

@codecov
Copy link

codecov bot commented Dec 6, 2023

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (2be0c28) 85.06% compared to head (37a4242) 85.03%.

Files Patch % Lines
.../hugegraph/computer/core/master/MasterService.java 84.00% 5 Missing and 3 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #292      +/-   ##
============================================
- Coverage     85.06%   85.03%   -0.04%     
+ Complexity     3297     3296       -1     
============================================
  Files           349      349              
  Lines         12478    12485       +7     
  Branches       1129     1130       +1     
============================================
+ Hits          10615    10616       +1     
- Misses         1325     1329       +4     
- Partials        538      540       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@simon824 simon824 merged commit e0b484a into master Dec 6, 2023
@simon824 simon824 deleted the improve_worker_id branch December 6, 2023 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants