Conversation
Completed the translation to English. Note: Under section 1.2.5, the Chinese text might be incorrect as it translates for me as: "Where age is the name of the PropertyKey to be obtained." The origional text is: ``` 其中,`age`为要获取的PropertyKey的名字 ``` However, I believe that the correct statement is: "Where `age` is the name of the PropertyKey to be deleted."
imbajin
reviewed
May 19, 2023
Comment on lines
-243
to
+242
| 其中,`age`为要获取的PropertyKey的名字 | ||
| Where `age` is the name of the PropertyKey to be deleted. |
Member
There was a problem hiding this comment.
Yep, nice catch, thanks for the correction, I'll update the CN doc now
imbajin
approved these changes
May 19, 2023
github-actions bot
pushed a commit
that referenced
this pull request
May 19, 2023
* Update propertykey.md --------- Co-authored-by: imbajin <jin@apache.org> b5fb8fb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completed the translation to English.
Note: Under section 1.2.5, the Chinese text might be incorrect as it translates for me as:
"Where age is the name of the PropertyKey to be obtained."
The origional text is:
However, I believe that the correct statement is:
"Where
ageis the name of the PropertyKey to be deleted."