Skip to content

Comments

doc: add server preload and hubble deploy#281

Merged
imbajin merged 14 commits intoapache:masterfrom
aroundabout:docker_update
Sep 12, 2023
Merged

doc: add server preload and hubble deploy#281
imbajin merged 14 commits intoapache:masterfrom
aroundabout:docker_update

Conversation

@aroundabout
Copy link
Contributor

main change

  1. add the server preload.
  2. add how to deploy hubble.

related issue

  1. [Feature] Support build docker image from Dockerfile (Task Summary) hugegraph#840

@imbajin imbajin requested a review from coderzc August 30, 2023 15:39
Copy link
Member

@imbajin imbajin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix CN first, then sync EN doc later

Comment on lines 64 to 80
2023-08-30 20:38:37 [main] [INFO ] o.a.c.h.Http11NioProtocol [] - Initializing ProtocolHandler ["http-nio-0.0.0.0-8088"]
2023-08-30 20:38:37 [main] [INFO ] o.a.c.c.StandardService [] - Starting service [Tomcat]
2023-08-30 20:38:37 [main] [INFO ] o.a.c.c.StandardEngine [] - Starting Servlet engine: [Apache Tomcat/9.0.24]
2023-08-30 20:38:37 [main] [INFO ] o.a.c.c.C.[.[.[/] [] - Initializing Spring embedded WebApplicationContext
2023-08-30 20:38:37 [main] [INFO ] c.z.h.HikariDataSource [] - hugegraph-hubble-HikariCP - Starting...
2023-08-30 20:38:38 [main] [INFO ] c.z.h.HikariDataSource [] - hugegraph-hubble-HikariCP - Start completed.
2023-08-30 20:38:41 [main] [INFO ] o.a.c.h.Http11NioProtocol [] - Starting ProtocolHandler ["http-nio-0.0.0.0-8088"]
2023-08-30 20:38:41 [main] [INFO ] o.a.h.HugeGraphHubble [] - Started HugeGraphHubble in 7.379 seconds (JVM running for 8.499)
flection.CachedClass
WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
WARNING: All illegal access operations will be denied in a future release
2023-08-30 20:38:37 [main] [INFO ] o.a.c.h.Http11NioProtocol [] - Initializing ProtocolHandler ["http-nio-0.0.0.0-8088"]
2023-08-30 20:38:37 [main] [INFO ] o.a.c.c.StandardService [] - Starting service [Tomcat]
2023-08-30 20:38:37 [main] [INFO ] o.a.c.c.StandardEngine [] - Starting Servlet engine: [Apache Tomcat/9.0.24]
2023-08-30 20:38:37 [main] [INFO ] o.a.c.c.C.[.[.[/] [] - Initializing Spring embedded WebApplicationContext
2023-08-30 20:38:37 [main] [INFO ] c.z.h.HikariDataSource [] - hugegraph-hubble-HikariCP - Starting...
2023-08-30 20:38:38 [main] [INFO ] c.z.h.HikariDataSource [] - hugegraph-hubble-HikariCP - Start completed.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could reduce useless log print 🖨️

Comment on lines 546 to 548
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 222 100 222 0 0 4625 0 --:--:-- --:--:-- --:--:-- 4625
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need print progress info

Comment on lines 586 to 588
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 222 100 222 0 0 4625 0 --:--:-- --:--:-- --:--:-- 4625
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

aroundabout and others added 11 commits September 10, 2023 09:16
Co-authored-by: imbajin <jin@apache.org>
Co-authored-by: imbajin <jin@apache.org>
Co-authored-by: imbajin <jin@apache.org>
Co-authored-by: imbajin <jin@apache.org>
Co-authored-by: imbajin <jin@apache.org>
Co-authored-by: imbajin <jin@apache.org>
Co-authored-by: imbajin <jin@apache.org>
Co-authored-by: imbajin <jin@apache.org>
Co-authored-by: imbajin <jin@apache.org>
Co-authored-by: imbajin <jin@apache.org>
Copy link
Contributor

@javeme javeme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice improvement


#### 2.2 源码编译

需要用户提前安装`yarn==16.x`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我们也给出一下安装命令?


#### 2.1 下载 toolchain 二进制包

首先下载tar包
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我们可以先说明一下:"hubble 在 toolchain 仓库中,首先下载 toolchain 的 tar 包"


#### 9.2 启动脚本时指定参数

在脚本启动时候携带 `-p true` 参数
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"...携带 -p true 参数表示xx"

javeme
javeme previously approved these changes Sep 10, 2023
Copy link
Contributor

@javeme javeme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@imbajin imbajin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sync the EN doc, and batch apply the suggestions (rather than apply them one by one)

image

Co-authored-by: imbajin <jin@apache.org>
Copy link
Member

@imbajin imbajin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, THX

@imbajin imbajin merged commit 156b9c7 into apache:master Sep 12, 2023
github-actions bot pushed a commit that referenced this pull request Sep 12, 2023
- add the server preload
- add how to deploy hubble
---------

Co-authored-by: imbajin <jin@apache.org> 156b9c7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants