feat: support use sql to construct graph for loader#263
Merged
imbajin merged 5 commits intoapache:masterfrom May 5, 2022
simon824:master
Merged
feat: support use sql to construct graph for loader#263imbajin merged 5 commits intoapache:masterfrom simon824:master
imbajin merged 5 commits intoapache:masterfrom
simon824:master
Conversation
Member
|
could u add a user case for it? (in the comment area) |
Member
Author
|
Member
Thanks. Do we have a minimal sql case for it? And it's useful for user-doc later |
Member
Author
select t1.name, t1.age, t2.city from t1 left join t2 on t1.id = t2.id where t2.date > '2021-01-01'I can help to update doc later. |
javeme
reviewed
Apr 29, 2022
hugegraph-loader/src/main/java/com/baidu/hugegraph/loader/source/jdbc/JDBCSource.java
Outdated
Show resolved
Hide resolved
hugegraph-loader/src/main/java/com/baidu/hugegraph/loader/reader/jdbc/RowFetcher.java
Outdated
Show resolved
Hide resolved
hugegraph-loader/src/main/java/com/baidu/hugegraph/loader/reader/jdbc/RowFetcher.java
Outdated
Show resolved
Hide resolved
javeme
reviewed
Apr 29, 2022
hugegraph-loader/src/main/java/com/baidu/hugegraph/loader/source/jdbc/JDBCSource.java
Outdated
Show resolved
Hide resolved
hugegraph-loader/src/main/java/com/baidu/hugegraph/loader/source/jdbc/JDBCSource.java
Show resolved
Hide resolved
hugegraph-loader/src/main/java/com/baidu/hugegraph/loader/reader/jdbc/RowFetcher.java
Outdated
Show resolved
Hide resolved
javeme
previously approved these changes
Apr 29, 2022
hugegraph-loader/src/main/java/com/baidu/hugegraph/loader/source/jdbc/JDBCSource.java
Outdated
Show resolved
Hide resolved
javeme
approved these changes
May 5, 2022
imbajin
approved these changes
May 5, 2022
Member
imbajin
left a comment
There was a problem hiding this comment.
Thanks, u could add a doc later
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closed #262