Skip to content

Comments

Add maven-clean-plugin for hubble#335

Merged
javeme merged 2 commits intoapache:masterfrom
simon824:patch-6
Oct 13, 2022
Merged

Add maven-clean-plugin for hubble#335
javeme merged 2 commits intoapache:masterfrom
simon824:patch-6

Conversation

@simon824
Copy link
Member

@simon824 simon824 commented Oct 8, 2022

Avoid creating too many temporary files by cp and add maven-clean-plugin for hubble to clean package files.

@codecov
Copy link

codecov bot commented Oct 8, 2022

Codecov Report

Merging #335 (84d8f86) into master (6d82b15) will increase coverage by 5.26%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #335      +/-   ##
============================================
+ Coverage     67.43%   72.69%   +5.26%     
- Complexity      878     1850     +972     
============================================
  Files            86      242     +156     
  Lines          4029     8109    +4080     
  Branches        477      719     +242     
============================================
+ Hits           2717     5895    +3178     
- Misses         1107     1830     +723     
- Partials        205      384     +179     
Impacted Files Coverage Δ
.../main/java/com/baidu/hugegraph/api/job/JobAPI.java 100.00% <0.00%> (ø)
...in/java/com/baidu/hugegraph/structure/Element.java 37.50% <0.00%> (ø)
.../baidu/hugegraph/structure/constant/IndexType.java 73.33% <0.00%> (ø)
...n/java/com/baidu/hugegraph/api/auth/AccessAPI.java 100.00% <0.00%> (ø)
.../com/baidu/hugegraph/structure/traverser/Kout.java 100.00% <0.00%> (ø)
...a/com/baidu/hugegraph/structure/SchemaElement.java 94.11% <0.00%> (ø)
...n/java/com/baidu/hugegraph/driver/TaskManager.java 28.57% <0.00%> (ø)
.../hugegraph/exception/InvalidResponseException.java 0.00% <0.00%> (ø)
...aidu/hugegraph/structure/constant/Cardinality.java 69.23% <0.00%> (ø)
...du/hugegraph/structure/traverser/CountRequest.java 75.00% <0.00%> (ø)
... and 146 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@imbajin imbajin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, shall we put the plugin in root's pom?

@simon824
Copy link
Member Author

simon824 commented Oct 9, 2022

thanks, shall we put the plugin in root's pom?

but seems different subprojects have different files to clean, maybe it's better to separate?

@javeme javeme merged commit 4d70db9 into apache:master Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants