Add maven-clean-plugin for hubble#335
Merged
javeme merged 2 commits intoapache:masterfrom Oct 13, 2022
simon824:patch-6
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #335 +/- ##
============================================
+ Coverage 67.43% 72.69% +5.26%
- Complexity 878 1850 +972
============================================
Files 86 242 +156
Lines 4029 8109 +4080
Branches 477 719 +242
============================================
+ Hits 2717 5895 +3178
- Misses 1107 1830 +723
- Partials 205 384 +179
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
imbajin
approved these changes
Oct 9, 2022
Member
imbajin
left a comment
There was a problem hiding this comment.
thanks, shall we put the plugin in root's pom?
Member
Author
but seems different subprojects have different files to clean, maybe it's better to separate? |
javeme
approved these changes
Oct 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid creating too many temporary files by
cpand addmaven-clean-pluginfor hubble to clean package files.