refact(client): adapt import & style with latest code#369
Merged
Conversation
check all class manually
imbajin
changed the title
Codecov Report
@@ Coverage Diff @@
## master #369 +/- ##
============================================
- Coverage 57.52% 57.40% -0.12%
Complexity 1864 1864
============================================
Files 263 263
Lines 10272 10244 -28
Branches 877 875 -2
============================================
- Hits 5909 5881 -28
Misses 3979 3979
Partials 384 384
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
javeme
reviewed
Nov 14, 2022
hugegraph-client/src/main/java/org/apache/hugegraph/structure/graph/Edge.java
Outdated
Show resolved
Hide resolved
| EdgeLabelApiTest.class, | ||
| IndexLabelApiTest.class, | ||
| SchemaApiTest.class, | ||
| PropertyKeyApiTest.class, |
Member
Author
There was a problem hiding this comment.
@javeme how many spaces shall we keep in @Annotation({p1, p2, p3}) ? Is 4 spaces right?
and we could unify the annotation style
hugegraph-client/src/test/java/org/apache/hugegraph/api/EdgeApiTest.java
Show resolved
Hide resolved
hugegraph-client/src/test/java/org/apache/hugegraph/api/TaskApiTest.java
Show resolved
Hide resolved
hugegraph-client/src/test/java/org/apache/hugegraph/api/TaskApiTest.java
Outdated
Show resolved
Hide resolved
| MetricsManagerTest.class, | ||
| HugeClientHttpsTest.class, | ||
| HugeClientTest.class | ||
| PropertyKeyTest.class, |
Member
Author
There was a problem hiding this comment.
same as the annotation style problem
| CommonUtilTest.class, | ||
| IdUtilTest.class, | ||
| SplicingIdGeneratorTest.class | ||
| VertexSerializerTest.class, |
|
|
||
| Edge peterCreateLop = new Edge("created").source(peter).target(lop).property("date", "2017-03-24"); | ||
| Edge peterCreateLop = new Edge("created").source(peter).target(lop) | ||
| .property("date", "2017-03-24"); |
Member
Author
There was a problem hiding this comment.
a little strange, it looks fine in ide
Oh, got the reason, the previous line have a virtual comment.... and I align it manually
javeme
approved these changes
Nov 17, 2022
zyxxoo
approved these changes
Nov 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
check all class in
clientmodule manuallyand the basic rule is we should avoid using a special align style, it's not friendly for normal users to format the code (Greatly reduces the efficiency of commit)
use the config file to format the file automatically is more sensible, and we could reduce to review the
space/align/empty line/wrong importalso.