chore(ci): add stage profile settings#536
Merged
simon824 merged 6 commits intoapache:masterfrom Nov 23, 2023
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #536 +/- ##
============================================
+ Coverage 62.47% 62.49% +0.02%
- Complexity 930 1903 +973
============================================
Files 93 262 +169
Lines 4509 9541 +5032
Branches 529 886 +357
============================================
+ Hits 2817 5963 +3146
- Misses 1483 3190 +1707
- Partials 209 388 +179 ☔ View full report in Codecov by Sentry. |
imbajin
reviewed
Nov 23, 2023
imbajin
previously approved these changes
Nov 23, 2023
imbajin
reviewed
Nov 23, 2023
Comment on lines
-43
to
-52
| - uses: actions/setup-java@v3 | ||
| with: | ||
| java-version: '11' | ||
| distribution: 'adopt' | ||
|
|
||
| - name: Use Node.js 16 | ||
| uses: actions/setup-node@v3 | ||
| with: | ||
| node-version: '16' | ||
|
|
Member
There was a problem hiding this comment.
seems we don't need set java/node env here, the github ubuntu action already have the maven env inside, so remove it now
imbajin
approved these changes
Nov 23, 2023
simon824
approved these changes
Nov 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of the PR
subtask of apache/hugegraph-commons#133
Main Changes
Verifying these changes
Does this PR potentially affect the following parts?
Documentation Status
Doc - TODODoc - DoneDoc - No Need