Skip to content

chore(client): increase the api num as the latest server commit + 10#546

Merged
simon824 merged 5 commits intoapache:masterfrom
aroundabout:api-update
Dec 5, 2023
Merged

chore(client): increase the api num as the latest server commit + 10#546
simon824 merged 5 commits intoapache:masterfrom
aroundabout:api-update

Conversation

@aroundabout
Copy link
Contributor

Purpose of the PR

Main Changes

  1. The right range of api version is set to 0.81 (0.71+10)
  2. Build client in dockerfile instead of using client:1.0.0

Verifying these changes

tested by this yaml, where dandelionivy/hubble is my own repo

version: '3'
services:
  server:
    image: hugegraph/hugegraph
    #image: dandelionivy/server
    container_name: graph
    ports:
      - 18081:8080

  hubble:
    #image: hugegraph/hubble
    image: dandelionivy/hubble
    container_name: hubble
    ports:
      - 8088:8088

now we can connect to the graph:
image

  • Trivial rework / code cleanup without any test coverage. (No Need)
  • Already covered by existing tests, such as (please modify tests here).
  • Need tests and can be verified as follows:
    • xxx

Does this PR potentially affect the following parts?

  • Nope
  • Dependencies (add/update license info)
  • Modify configurations
  • The public API
  • Other affects (typed here)

Documentation Status

  • Doc - TODO
  • Doc - Done
  • Doc - No Need

@github-actions github-actions bot added hubble hugegraph-hubble client hugegraph-client labels Dec 4, 2023
@liuxiaocs7
Copy link
Contributor

Note: now the api version check range is: [0.38, 0.81)

Copy link
Member

@imbajin imbajin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add need update the depth param in install-from-server script for ci

private void checkServerApiVersion() {
VersionUtil.Version apiVersion = VersionUtil.Version.of(this.version.getApiVersion());
VersionUtil.check(apiVersion, "0.38", "0.70", "hugegraph-api in server");
VersionUtil.check(apiVersion, "0.38", "0.81", "hugegraph-api in server");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a comment for it (like why we need keep it as realNum + 10)

simon824
simon824 previously approved these changes Dec 5, 2023
@github-actions github-actions bot added loader hugegraph-loader tools hugegraph-tools labels Dec 5, 2023
Comment on lines 112 to 113
# TODO: find a way to keep the range of api version correct automatically
# 0.81 equals to the {latest_api_version} +10
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line comments in java code should be // rather than #?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I made a mistake. It was a simple error.

@codecov
Copy link

codecov bot commented Dec 5, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e8fd3e0) 62.49% compared to head (5f5285e) 62.49%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #546   +/-   ##
=========================================
  Coverage     62.49%   62.49%           
  Complexity     1903     1903           
=========================================
  Files           262      262           
  Lines          9541     9541           
  Branches        886      886           
=========================================
  Hits           5963     5963           
  Misses         3190     3190           
  Partials        388      388           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@imbajin imbajin changed the title [fix] api version is outdated in client chore(client): increase the api num as the latest server commit + 10 Dec 5, 2023
@simon824 simon824 merged commit b066b80 into apache:master Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

client hugegraph-client hubble hugegraph-hubble loader hugegraph-loader tools hugegraph-tools

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Api version of client is outdated

4 participants