chore(client): increase the api num as the latest server commit + 10#546
Merged
simon824 merged 5 commits intoapache:masterfrom Dec 5, 2023
Merged
chore(client): increase the api num as the latest server commit + 10#546simon824 merged 5 commits intoapache:masterfrom
simon824 merged 5 commits intoapache:masterfrom
Conversation
1 task
Contributor
|
Note: now the api version check range is: |
liuxiaocs7
approved these changes
Dec 4, 2023
11 tasks
imbajin
reviewed
Dec 4, 2023
Member
imbajin
left a comment
There was a problem hiding this comment.
add need update the depth param in install-from-server script for ci
| private void checkServerApiVersion() { | ||
| VersionUtil.Version apiVersion = VersionUtil.Version.of(this.version.getApiVersion()); | ||
| VersionUtil.check(apiVersion, "0.38", "0.70", "hugegraph-api in server"); | ||
| VersionUtil.check(apiVersion, "0.38", "0.81", "hugegraph-api in server"); |
Member
There was a problem hiding this comment.
add a comment for it (like why we need keep it as realNum + 10)
aroundabout
commented
Dec 4, 2023
hugegraph-client/src/main/java/org/apache/hugegraph/driver/HugeClient.java
Show resolved
Hide resolved
simon824
previously approved these changes
Dec 5, 2023
liuxiaocs7
reviewed
Dec 5, 2023
Comment on lines
112
to
113
| # TODO: find a way to keep the range of api version correct automatically | ||
| # 0.81 equals to the {latest_api_version} +10 |
Contributor
There was a problem hiding this comment.
Line comments in java code should be // rather than #?
Contributor
Author
There was a problem hiding this comment.
Sorry, I made a mistake. It was a simple error.
aroundabout
commented
Dec 5, 2023
hugegraph-client/src/main/java/org/apache/hugegraph/driver/HugeClient.java
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #546 +/- ##
=========================================
Coverage 62.49% 62.49%
Complexity 1903 1903
=========================================
Files 262 262
Lines 9541 9541
Branches 886 886
=========================================
Hits 5963 5963
Misses 3190 3190
Partials 388 388 ☔ View full report in Codecov by Sentry. |
imbajin
approved these changes
Dec 5, 2023
simon824
approved these changes
Dec 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of the PR
Main Changes
Verifying these changes
tested by this yaml, where dandelionivy/hubble is my own repo
now we can connect to the graph:

Does this PR potentially affect the following parts?
Documentation Status
Doc - TODODoc - DoneDoc - No Need