Skip to content

fix: github action build docker image failed during the release 1.2 process#556

Merged
simon824 merged 8 commits intoapache:masterfrom
aroundabout:adapt-1.2
Dec 13, 2023
Merged

fix: github action build docker image failed during the release 1.2 process#556
simon824 merged 8 commits intoapache:masterfrom
aroundabout:adapt-1.2

Conversation

@aroundabout
Copy link
Contributor

@aroundabout aroundabout commented Dec 13, 2023

Purpose of the PR

Github action for building docker image failed https://github.com/hugegraph/actions/actions
image

Main Changes

  • In Dockerfile, we can use mvn install $MAVEN_ARGS
  • During releasing 1.2, we should use mvn -P stage to use apache stage repo. But currently, the dockerfile cannot use the -P stage. Hence, I add the MAVEN_ARGS which can be passed in the following way in github action:
      uses: docker/build-push-action@v5
      with:
        ......
        build-args: ${{ env.MVN_ARGS }}

The MVN_ARGS can be set to MAVEN_ARGS=-P stage

Build successfully in my own repo
image

Related PR

https://github.com/hugegraph/actions/pull/4
apache/hugegraph#2386

Verifying these changes

  • Trivial rework / code cleanup without any test coverage. (No Need)
  • Already covered by existing tests, such as (please modify tests here).
  • Need tests and can be verified as follows:
    • xxx

Does this PR potentially affect the following parts?

  • Nope
  • Dependencies (add/update license info)
  • Modify configurations
  • The public API
  • Other affects (typed here)

Documentation Status

  • Doc - TODO
  • Doc - Done
  • Doc - No Need

@codecov
Copy link

codecov bot commented Dec 13, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (b066b80) 62.49% compared to head (b790f51) 62.47%.
Report is 12 commits behind head on master.

Files Patch % Lines
...egraph/loader/direct/loader/HBaseDirectLoader.java 0.00% 2 Missing ⚠️
.../apache/hugegraph/loader/executor/LoadOptions.java 33.33% 2 Missing ⚠️
...e/hugegraph/loader/spark/HugeGraphSparkLoader.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #556      +/-   ##
============================================
- Coverage     62.49%   62.47%   -0.03%     
+ Complexity     1903      930     -973     
============================================
  Files           262       93     -169     
  Lines          9541     4509    -5032     
  Branches        886      529     -357     
============================================
- Hits           5963     2817    -3146     
+ Misses         3190     1483    -1707     
+ Partials        388      209     -179     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@simon824 simon824 merged commit b51443c into apache:master Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hubble hugegraph-hubble loader hugegraph-loader

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants