fix: github action build docker image failed during the release 1.2 process#556
Merged
simon824 merged 8 commits intoapache:masterfrom Dec 13, 2023
Merged
fix: github action build docker image failed during the release 1.2 process#556simon824 merged 8 commits intoapache:masterfrom
simon824 merged 8 commits intoapache:masterfrom
Conversation
Merged
11 tasks
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #556 +/- ##
============================================
- Coverage 62.49% 62.47% -0.03%
+ Complexity 1903 930 -973
============================================
Files 262 93 -169
Lines 9541 4509 -5032
Branches 886 529 -357
============================================
- Hits 5963 2817 -3146
+ Misses 3190 1483 -1707
+ Partials 388 209 -179 ☔ View full report in Codecov by Sentry. |
liuxiaocs7
approved these changes
Dec 13, 2023
imbajin
approved these changes
Dec 13, 2023
simon824
approved these changes
Dec 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of the PR
Github action for building docker image failed https://github.com/hugegraph/actions/actions

Main Changes
mvn install $MAVEN_ARGSmvn -P stageto use apache stage repo. But currently, the dockerfile cannot use the -P stage. Hence, I add the MAVEN_ARGS which can be passed in the following way in github action:The
MVN_ARGScan be set toMAVEN_ARGS=-P stageBuild successfully in my own repo

Related PR
https://github.com/hugegraph/actions/pull/4
apache/hugegraph#2386
Verifying these changes
Does this PR potentially affect the following parts?
Documentation Status
Doc - TODODoc - DoneDoc - No Need