Skip to content

doc: adjust docker related desc in readme#559

Merged
simon824 merged 5 commits intoapache:masterfrom
aroundabout:docfix-1.2.0
Dec 17, 2023
Merged

doc: adjust docker related desc in readme#559
simon824 merged 5 commits intoapache:masterfrom
aroundabout:docfix-1.2.0

Conversation

@aroundabout
Copy link
Contributor

Purpose of the PR

  • add ASF docker policy
  • and recommend users to use the release tag instead of latest

Main Changes

Verifying these changes

  • Trivial rework / code cleanup without any test coverage. (No Need)
  • Already covered by existing tests, such as (please modify tests here).
  • Need tests and can be verified as follows:
    • xxx

Does this PR potentially affect the following parts?

  • Nope
  • Dependencies (add/update license info)
  • Modify configurations
  • The public API
  • Other affects (typed here)

Documentation Status

  • Doc - TODO
  • Doc - Done
  • Doc - No Need

@aroundabout aroundabout marked this pull request as draft December 15, 2023 13:29
@github-actions github-actions bot added hubble hugegraph-hubble loader hugegraph-loader labels Dec 15, 2023
@codecov
Copy link

codecov bot commented Dec 15, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (b066b80) 62.49% compared to head (a22a0d1) 62.47%.
Report is 16 commits behind head on master.

Files Patch % Lines
...egraph/loader/direct/loader/HBaseDirectLoader.java 0.00% 2 Missing ⚠️
.../apache/hugegraph/loader/executor/LoadOptions.java 33.33% 2 Missing ⚠️
...e/hugegraph/loader/spark/HugeGraphSparkLoader.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #559      +/-   ##
============================================
- Coverage     62.49%   62.47%   -0.03%     
+ Complexity     1903      930     -973     
============================================
  Files           262       93     -169     
  Lines          9541     4509    -5032     
  Branches        886      529     -357     
============================================
- Hits           5963     2817    -3146     
+ Misses         3190     1483    -1707     
+ Partials        388      209     -179     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aroundabout aroundabout marked this pull request as ready for review December 15, 2023 14:01
@aroundabout aroundabout changed the title doc: add ASF docker policy doc: adjust docker related desc Dec 16, 2023
@aroundabout aroundabout changed the title doc: adjust docker related desc doc: adjust README desc Dec 16, 2023
@aroundabout aroundabout changed the title doc: adjust README desc doc: adjust docker related desc in readme Dec 16, 2023
@imbajin imbajin changed the base branch from release-1.2.0 to master December 16, 2023 16:38
imbajin
imbajin previously approved these changes Dec 16, 2023
Copy link
Member

@imbajin imbajin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THX, almost LGTM

@simon824 simon824 merged commit 773469c into apache:master Dec 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hubble hugegraph-hubble loader hugegraph-loader

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants