fix: concurrency issue causing file overwrite due to identical filenames#572
Merged
fix: concurrency issue causing file overwrite due to identical filenames#572
Conversation
dosubot
bot
added
the
size:M
imbajin
reviewed
Feb 1, 2024
Comment on lines
+106
to
+126
| public static String fileID() { | ||
| long timeStamp = System.currentTimeMillis() / 1000; | ||
| ByteBuffer byteBuffer = ByteBuffer.allocate(12); | ||
|
|
||
| byteBuffer.put(int3((int) timeStamp)); | ||
| byteBuffer.put(int2((int) timeStamp)); | ||
| byteBuffer.put(int1((int) timeStamp)); | ||
| byteBuffer.put(int0((int) timeStamp)); | ||
|
|
||
| byteBuffer.put(int2(RANDOM_VALUE1)); | ||
| byteBuffer.put(int1(RANDOM_VALUE1)); | ||
| byteBuffer.put(int0(RANDOM_VALUE1)); | ||
| byteBuffer.put(short1(RANDOM_VALUE2)); | ||
| byteBuffer.put(short0(RANDOM_VALUE2)); | ||
|
|
||
| byteBuffer.put(int2(NEXT_COUNTER.incrementAndGet())); | ||
| byteBuffer.put(int1(NEXT_COUNTER.incrementAndGet())); | ||
| byteBuffer.put(int0(NEXT_COUNTER.incrementAndGet())); | ||
|
|
||
| return Bytes.toHex(byteBuffer.array()); | ||
| } |
Member
There was a problem hiding this comment.
maybe we could leave/show a simple case for it? (hard to know the generated str now)
imbajin
approved these changes
Feb 20, 2024
javeme
approved these changes
Feb 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of the PR
Main Changes
Verifying these changes
Does this PR potentially affect the following parts?
Documentation Status
Doc - TODODoc - DoneDoc - No Need