Fix bug vertices with CUSTOMIZE_NUMBER id load error#6
Merged
Conversation
zhoney
reviewed
Oct 11, 2018
| schema.indexLabel("personByName").onV("person").by("name").secondary().ifNotExist().create(); | ||
| schema.indexLabel("personByAge").onV("person").by("age").range().ifNotExist().create(); | ||
| schema.indexLabel("personByCity").onV("person").by("city").secondary().ifNotExist().create(); | ||
| schema.indexLabel("personByAgeAndCity").onV("person").by("age", "city").secondary().ifNotExist().create(); No newline at end of file |
| "id": "id" | ||
| } | ||
| ] | ||
| } No newline at end of file |
javeme
requested changes
Oct 11, 2018
|
|
||
| private Long parseNumberId(Object idValue) { | ||
| if (idValue instanceof Number) { | ||
| return (Long) idValue; |
Contributor
There was a problem hiding this comment.
it may be other number type eg. int or float, so use idValue.longValue()
| } | ||
| } | ||
|
|
||
| private Long parseNumberId(Object idValue) { |
Fix #5 Change-Id: I7cd495b3e27e128cd5c9d75d9ebd54fdbc5bca21
Linary
force-pushed
the
support-customize-number-id
branch
from
153fae0 to
57e349e
Compare
Contributor
Author
|
done |
javeme
approved these changes
Oct 12, 2018
zhoney
approved these changes
Oct 29, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.