Conversation
Change-Id: I36cf1e0093fb34837e5c5f46ace91c38eae10a74
Codecov Report
@@ Coverage Diff @@
## master #1423 +/- ##
=========================================
Coverage 62.22% 62.23%
+ Complexity 5855 5853 -2
=========================================
Files 381 381
Lines 32109 32096 -13
Branches 4492 4491 -1
=========================================
- Hits 19981 19976 -5
+ Misses 10091 10082 -9
- Partials 2037 2038 +1
Continue to review full report at Codecov.
|
Linary
requested changes
Apr 19, 2021
| } | ||
|
|
||
| // NOTE: Jraft itself doesn't have this callback, it's added by us | ||
| @SuppressWarnings("unused") |
Contributor
There was a problem hiding this comment.
remove it. Don't write misleading annotation to shield warnings
Change-Id: Ibcd2092562c8893a4f6a1f86f727bfe4da90db83
Change-Id: I75b25240585773932602c54610e38324285c42ca
Linary
approved these changes
Apr 22, 2021
houzhizhen
approved these changes
Apr 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change-Id: I36cf1e0093fb34837e5c5f46ace91c38eae10a74