refact: unify naming of degree for oltp algorithms#1433
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1433 +/- ##
============================================
+ Coverage 62.25% 62.27% +0.01%
- Complexity 5861 5863 +2
============================================
Files 381 381
Lines 32139 32139
Branches 4504 4504
============================================
+ Hits 20009 20014 +5
+ Misses 10076 10071 -5
Partials 2054 2054
Continue to review full report at Codecov.
|
Linary
requested changes
Apr 27, 2021
hugegraph-api/src/main/java/com/baidu/hugegraph/api/traversers/CountAPI.java
Outdated
Show resolved
Hide resolved
javeme
reviewed
Apr 28, 2021
hugegraph-api/src/main/java/com/baidu/hugegraph/api/traversers/CountAPI.java
Outdated
Show resolved
Hide resolved
hugegraph-api/src/main/java/com/baidu/hugegraph/api/traversers/CustomizedCrosspointsAPI.java
Outdated
Show resolved
Hide resolved
hugegraph-api/src/main/java/com/baidu/hugegraph/api/traversers/FusiformSimilarityAPI.java
Outdated
Show resolved
Hide resolved
hugegraph-api/src/main/java/com/baidu/hugegraph/api/traversers/PersonalRankAPI.java
Outdated
Show resolved
Hide resolved
...graph-core/src/main/java/com/baidu/hugegraph/traversal/algorithm/steps/WeightedEdgeStep.java
Outdated
Show resolved
Hide resolved
...graph-core/src/main/java/com/baidu/hugegraph/traversal/algorithm/steps/WeightedEdgeStep.java
Outdated
Show resolved
Hide resolved
javeme
reviewed
May 6, 2021
hugegraph-api/src/main/java/com/baidu/hugegraph/api/traversers/PersonalRankAPI.java
Outdated
Show resolved
Hide resolved
hugegraph-api/src/main/java/com/baidu/hugegraph/api/traversers/NeighborRankAPI.java
Show resolved
Hide resolved
hugegraph-api/src/main/java/com/baidu/hugegraph/api/traversers/TraverserAPI.java
Show resolved
Hide resolved
| private double alpha; | ||
| @JsonProperty("degree") | ||
| private long degree = Long.valueOf(DEFAULT_DEGREE); | ||
| @JsonProperty("max_degree") |
Contributor
There was a problem hiding this comment.
this param is not in a step, don't need alias
hugegraph-api/src/main/java/com/baidu/hugegraph/api/traversers/CustomizedPathsAPI.java
Show resolved
Hide resolved
hugegraph-api/src/main/java/com/baidu/hugegraph/api/traversers/CustomizedCrosspointsAPI.java
Show resolved
Hide resolved
hugegraph-api/src/main/java/com/baidu/hugegraph/api/traversers/CountAPI.java
Show resolved
Hide resolved
javeme
reviewed
May 7, 2021
hugegraph-api/src/main/java/com/baidu/hugegraph/version/ApiVersion.java
Outdated
Show resolved
Hide resolved
hugegraph-api/src/main/java/com/baidu/hugegraph/version/ApiVersion.java
Outdated
Show resolved
Hide resolved
...graph-core/src/main/java/com/baidu/hugegraph/traversal/algorithm/steps/WeightedEdgeStep.java
Outdated
Show resolved
Hide resolved
javeme
previously approved these changes
May 7, 2021
imbajin
changed the title
zhoney
approved these changes
May 11, 2021
zhoney
requested changes
May 11, 2021
hugegraph-api/src/main/java/com/baidu/hugegraph/api/traversers/AllShortestPathsAPI.java
Show resolved
Hide resolved
zhoney
requested changes
May 11, 2021
hugegraph-api/src/main/java/com/baidu/hugegraph/version/ApiVersion.java
Outdated
Show resolved
Hide resolved
imbajin
changed the title
zhoney
approved these changes
May 12, 2021
javeme
approved these changes
May 12, 2021
Linary
approved these changes
May 12, 2021
zhoney
pushed a commit
that referenced
this pull request
May 27, 2021
* refact: remove redundant packaging * refact: keep compatible with degree in 'step' * update api version to 0.61 Change-Id: Ibbfcaab820eed9d4131a5544899a5e3829729201
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: also keep
degreefor alias inStep*request