Support newly added node install and resume snapshot#1439
Merged
Conversation
Change-Id: I974d9ec3d05eed02123191a8fe0916163fe59811
javeme
reviewed
Apr 30, 2021
| * Don't perform decompression, it's possible to trigger the bug of | ||
| * IOUtils.skip() infinite loop. I don't know how this bug is | ||
| * generated yet. | ||
| */ |
Contributor
There was a problem hiding this comment.
where is the snapshot data from
Contributor
Author
There was a problem hiding this comment.
from linked directory. The decompressed file is just manifest.
Contributor
There was a problem hiding this comment.
What is the snapshot recovery process when add newly raft node?
Change-Id: I0bb904a967eaada26b51b9b47bbfde5d31653bd1
Linary
changed the title
javeme
reviewed
May 17, 2021
hugegraph-rocksdb/src/main/java/com/baidu/hugegraph/backend/store/rocksdb/RocksDBStore.java
Outdated
Show resolved
Hide resolved
hugegraph-rocksdb/src/main/java/com/baidu/hugegraph/backend/store/rocksdb/RocksDBStore.java
Outdated
Show resolved
Hide resolved
| */ | ||
| this.compressJraftSnapshotDir(writer, jraftSnapshotPath, done); | ||
| this.compressSnapshotDir(writer, snapshotDirMaps, done); | ||
| this.deleteSnapshotDirs(snapshotDirMaps.keySet()); |
Contributor
There was a problem hiding this comment.
catch compressSnapshotDir and deleteSnapshotDirs
hugegraph-rocksdb/src/main/java/com/baidu/hugegraph/backend/store/rocksdb/RocksDBStore.java
Outdated
Show resolved
Hide resolved
hugegraph-rocksdb/src/main/java/com/baidu/hugegraph/backend/store/rocksdb/RocksDBStore.java
Outdated
Show resolved
Hide resolved
Change-Id: I3b0117fb9eddf2f4775f17ef1a30775367a48020
javeme
approved these changes
May 18, 2021
Codecov Report
@@ Coverage Diff @@
## master #1439 +/- ##
============================================
- Coverage 62.21% 62.05% -0.16%
- Complexity 5857 5861 +4
============================================
Files 381 381
Lines 32135 32248 +113
Branches 4504 4527 +23
============================================
+ Hits 19994 20013 +19
- Misses 10089 10179 +90
- Partials 2052 2056 +4
Continue to review full report at Codecov.
|
zhoney
approved these changes
May 19, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change-Id: I974d9ec3d05eed02123191a8fe0916163fe59811