chore: java 11 version support by zyxxoo · Pull Request #1653 · apache/hugegraph

zyxxoo · 2021-11-13T10:11:28Z

No description provided.

javeme

nice improvement, can also add java 11 env test to travis matrix

hugegraph-api/src/main/java/com/baidu/hugegraph/auth/HugeFactoryAuthProxy.java

hugegraph-core/src/main/java/com/baidu/hugegraph/util/ReflectionProxy.java

codecov · 2021-11-14T04:41:45Z

Codecov Report

Merging #1653 (29d169e) into master (e6a24fc) will increase coverage by 4.46%.
The diff coverage is 48.92%.

@@             Coverage Diff              @@
##             master    #1653      +/-   ##
============================================
+ Coverage     66.29%   70.75%   +4.46%     
  Complexity      980      980              
============================================
  Files           446      447       +1     
  Lines         37970    38040      +70     
  Branches       5411     5389      -22     
============================================
+ Hits          25172    26916    +1744     
+ Misses        10097     8492    -1605     
+ Partials       2701     2632      -69

Impacted Files	Coverage Δ
...api/src/main/java/com/baidu/hugegraph/api/API.java	`75.00% <ø> (ø)`
...n/java/com/baidu/hugegraph/api/auth/AccessAPI.java	`0.00% <ø> (ø)`
...n/java/com/baidu/hugegraph/api/auth/BelongAPI.java	`0.00% <ø> (ø)`
...in/java/com/baidu/hugegraph/api/auth/GroupAPI.java	`0.00% <ø> (ø)`
...in/java/com/baidu/hugegraph/api/auth/LoginAPI.java	`74.28% <ø> (ø)`
.../java/com/baidu/hugegraph/api/auth/ProjectAPI.java	`82.05% <ø> (ø)`
...n/java/com/baidu/hugegraph/api/auth/TargetAPI.java	`0.00% <ø> (ø)`
...ain/java/com/baidu/hugegraph/api/auth/UserAPI.java	`75.80% <ø> (ø)`
...idu/hugegraph/api/filter/AuthenticationFilter.java	`55.44% <ø> (+0.99%)`	⬆️
...aidu/hugegraph/api/filter/CompressInterceptor.java	`73.07% <ø> (ø)`
... and 272 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6a24fc...29d169e. Read the comment docs.

github-actions · 2021-12-23T21:13:06Z

Due to the lack of activity, the current pr is marked as stale and will be closed after 180 days, any update will remove the stale label

hugegraph-core/src/main/java/com/baidu/hugegraph/util/ConfigUtil.java

hugegraph-core/src/main/java/com/baidu/hugegraph/util/Reflection.java

hugegraph-dist/src/assembly/static/bin/hugegraph-server.sh

hugegraph-dist/src/assembly/static/conf/graphs/hugegraph.properties

hugegraph-dist/src/assembly/static/conf/gremlin-server.yaml

hugegraph-core/src/main/java/com/baidu/hugegraph/util/Reflection.java

javeme · 2022-04-09T15:11:59Z

hugegraph-core/src/main/java/com/baidu/hugegraph/util/Reflection.java

+        Method registerFieldsToFilterMethodTemp = null;
+        Method registerMethodsToFilterMethodTemp = null;
+        Class reflectionClazzTemp = null;


hugegraph-core/src/main/java/com/baidu/hugegraph/util/Reflection.java

javeme · 2022-04-24T16:04:44Z

we can ignore cassandra error #1843 in this commit

javeme · 2022-04-25T06:05:10Z

ci errors:

Error: Exception in thread "main" com.baidu.hugegraph.exception.ConnectionException: Failed to connect to Cassandra
	at com.baidu.hugegraph.backend.store.cassandra.CassandraStore.open(CassandraStore.java:189)
	at com.baidu.hugegraph.backend.tx.AbstractTransaction.<init>(AbstractTransaction.java:82)
	at com.baidu.hugegraph.backend.tx.IndexableTransaction.<init>(IndexableTransaction.java:30)
	at com.baidu.hugegraph.backend.tx.SchemaTransaction.<init>(SchemaTransaction.java:75)
	at com.baidu.hugegraph.backend.cache.CachedSchemaTransaction.<init>(CachedSchemaTransaction.java:54)
	at com.baidu.hugegraph.StandardHugeGraph.openSchemaTransaction(StandardHugeGraph.java:413)
	at com.baidu.hugegraph.StandardHugeGraph.access$2600(StandardHugeGraph.java:112)
	at com.baidu.hugegraph.StandardHugeGraph$TinkerPopTransaction.getOrNewTransaction(StandardHugeGraph.java:1388)
	at com.baidu.hugegraph.StandardHugeGraph$TinkerPopTransaction.schemaTransaction(StandardHugeGraph.java:1364)
	at com.baidu.hugegraph.StandardHugeGraph$TinkerPopTransaction.access$100(StandardHugeGraph.java:1234)
	at com.baidu.hugegraph.StandardHugeGraph.schemaTransaction(StandardHugeGraph.java:470)
	at com.baidu.hugegraph.StandardHugeGraph.backendStoreSystemInfo(StandardHugeGraph.java:249)
	at com.baidu.hugegraph.auth.HugeGraphAuthProxy.backendStoreSystemInfo(HugeGraphAuthProxy.java:615)
	at com.baidu.hugegraph.cmd.InitStore.initGraph(InitStore.java:94)
	at com.baidu.hugegraph.cmd.InitStore.main(InitStore.java:79)
Caused by: java.lang.NoClassDefFoundError: com/codahale/metrics/JmxReporter
	at com.datastax.driver.core.Metrics.<init>(Metrics.java:146)
	at com.datastax.driver.core.Cluster$Manager.init(Cluster.java:1501)
	at com.datastax.driver.core.Cluster.init(Cluster.java:208)
	at com.datastax.driver.core.Cluster.connectAsync(Cluster.java:376)
	at com.datastax.driver.core.Cluster.connect(Cluster.java:332)
	at com.baidu.hugegraph.backend.store.cassandra.CassandraSessionPool$Session.open(CassandraSessionPool.java:216)
	at com.baidu.hugegraph.backend.store.cassandra.CassandraStore.open(CassandraStore.java:171)
	... 14 more
Caused by: java.lang.ClassNotFoundException: com.codahale.metrics.JmxReporter
	at java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:581)
	at java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:178)
	at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:522)
	... 21 more
Error: The operation was canceled.

...assandra/src/main/java/com/baidu/hugegraph/backend/store/cassandra/CassandraSessionPool.java

chore: improve code chore: improve glassfish version chore: upgrade 3th lib fix: some api unit test fix: core test fix: resolve confict and improve common version fix: startup error by script chore: fix conflict chore: resolve backend test default dont use auth, and fix raft unit startup error default dont use auth, and fix raft unit startup error add permission verify add some comments improve cassandra version improve code remove empty file fix: drop graph fix: drop graph

...assandra/src/main/java/com/baidu/hugegraph/backend/store/cassandra/CassandraSessionPool.java

imbajin · 2022-04-25T10:50:46Z

hugegraph-test/src/main/java/com/baidu/hugegraph/tinkerpop/TestGraphFactory.java

-import org.apache.commons.configuration.Configuration;
-
 import com.baidu.hugegraph.HugeFactory;
+import org.apache.commons.configuration2.Configuration;


is the order right? (the original keep them divide?)

imbajin · 2022-04-25T10:51:55Z

hugegraph-test/src/main/java/com/baidu/hugegraph/unit/cassandra/CassandraTest.java


-import org.apache.commons.configuration.Configuration;
-import org.apache.commons.configuration.PropertiesConfiguration;
+import com.baidu.hugegraph.config.OptionSpace;


after renaming to apache package and enable style-check, then fix the import style uniformly.

imbajin · 2022-04-25T11:13:19Z

And could we use JDK11 grammar and build a JDK8-compatible package?

zyxxoo force-pushed the zy_dev branch 2 times, most recently from e14b293 to 9cb3b41 Compare November 13, 2021 11:20

javeme reviewed Nov 13, 2021

View reviewed changes

zyxxoo force-pushed the zy_dev branch from 9cb3b41 to d9f518c Compare November 14, 2021 04:34

zyxxoo force-pushed the zy_dev branch from d9f518c to ed4de19 Compare November 14, 2021 05:34

zyxxoo changed the title ~~chore: improve java 11 version support~~ chore: improve java 17 version support Nov 14, 2021

zyxxoo force-pushed the zy_dev branch from b399d25 to 5e92fb1 Compare November 14, 2021 05:53

zyxxoo changed the title ~~chore: improve java 17 version support~~ chore: java 17 version support Nov 14, 2021

zyxxoo force-pushed the zy_dev branch 3 times, most recently from 7125736 to 66676cf Compare November 15, 2021 02:22

zyxxoo force-pushed the zy_dev branch from 5152b3f to a6dd382 Compare November 23, 2021 05:07

github-actions bot added the inactive label Dec 23, 2021

javeme added java17 Upgrade to java 17+ java11 Upgrade to java 11+ and removed inactive labels Dec 24, 2021

zyxxoo force-pushed the zy_dev branch 2 times, most recently from 697e0de to 77b47b8 Compare January 11, 2022 13:19

zyxxoo changed the title ~~chore: java 17 version support~~ chore: java 11 version support Jan 11, 2022

javeme reviewed Jan 12, 2022

View reviewed changes

zyxxoo force-pushed the zy_dev branch 3 times, most recently from 632f425 to fae550e Compare January 18, 2022 10:07

zyxxoo force-pushed the zy_dev branch 5 times, most recently from d7917e6 to c85880e Compare January 24, 2022 07:37

javeme reviewed Apr 9, 2022

View reviewed changes

zyxxoo force-pushed the zy_dev branch 3 times, most recently from bf593cb to 8e483ba Compare April 12, 2022 10:43

zyxxoo force-pushed the zy_dev branch 2 times, most recently from 0f59476 to 158c754 Compare April 24, 2022 14:51

javeme reviewed Apr 25, 2022

View reviewed changes

...assandra/src/main/java/com/baidu/hugegraph/backend/store/cassandra/CassandraSessionPool.java Show resolved Hide resolved

zyxxoo added 11 commits April 25, 2022 14:32

improve code

91711fe

improve code

5237369

improve code

4f92736

improve code

25edda0

improve code

f820ae0

improve jacoco version

b8faf22

hugegraph-common version 2.1.2

bced158

improve jacoco agent and cli version

89e0b66

disable cassandra metrics

d2bfe71

add annotation for metrics disable

0866d03

zyxxoo force-pushed the zy_dev branch from f998c0c to 0866d03 Compare April 25, 2022 06:32

javeme reviewed Apr 25, 2022

View reviewed changes

...assandra/src/main/java/com/baidu/hugegraph/backend/store/cassandra/CassandraSessionPool.java Outdated Show resolved Hide resolved

zyxxoo added 2 commits April 25, 2022 15:12

improve code

655f595

improve code

29d169e

javeme approved these changes Apr 25, 2022

View reviewed changes

imbajin reviewed Apr 25, 2022

View reviewed changes

imbajin approved these changes Apr 25, 2022

View reviewed changes

imbajin merged commit 85b01b2 into master Apr 25, 2022

imbajin deleted the zy_dev branch April 25, 2022 11:13

Comments

Conversation

zyxxoo commented Nov 13, 2021

Uh oh!

javeme left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Nov 14, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented Dec 23, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

javeme Apr 9, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

javeme commented Apr 24, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

javeme commented Apr 25, 2022

Uh oh!

Uh oh!

Uh oh!

imbajin Apr 25, 2022

Choose a reason for hiding this comment

Uh oh!

imbajin Apr 25, 2022

Choose a reason for hiding this comment

Uh oh!

javeme Apr 25, 2022

Choose a reason for hiding this comment

Uh oh!

imbajin Apr 25, 2022

Choose a reason for hiding this comment

Uh oh!

imbajin commented Apr 25, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov bot commented Nov 14, 2021 •

edited

Loading

javeme commented Apr 24, 2022 •

edited

Loading