fix cassandra&rocksdb&scylladb code checkstyle#1847
Merged
javeme merged 18 commits intoapache:masterfrom May 10, 2022
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1847 +/- ##
============================================
+ Coverage 70.70% 70.96% +0.26%
Complexity 980 980
============================================
Files 447 447
Lines 38041 38076 +35
Branches 5389 5401 +12
============================================
+ Hits 26897 27021 +124
+ Misses 8508 8408 -100
- Partials 2636 2647 +11
Continue to review full report at Codecov.
|
javeme
reviewed
Apr 25, 2022
hugegraph-rocksdb/src/main/java/com/baidu/hugegraph/backend/store/rocksdb/RocksDBTables.java
Show resolved
Hide resolved
hugegraph-rocksdb/src/main/java/com/baidu/hugegraph/backend/store/rocksdb/RocksDBTables.java
Show resolved
Hide resolved
javeme
requested changes
Apr 26, 2022
Contributor
javeme
left a comment
There was a problem hiding this comment.
Still need to fix code logic changes
seagle-yuan
reviewed
Apr 26, 2022
...raph-rocksdb/src/main/java/com/baidu/hugegraph/backend/store/rocksdb/RocksDBStdSessions.java
Outdated
Show resolved
Hide resolved
javeme
reviewed
Apr 27, 2022
hugegraph-rocksdb/src/main/java/com/baidu/hugegraph/backend/store/rocksdb/RocksDBOptions.java
Outdated
Show resolved
Hide resolved
...raph-rocksdb/src/main/java/com/baidu/hugegraph/backend/store/rocksdb/RocksDBStdSessions.java
Outdated
Show resolved
Hide resolved
...raph-rocksdb/src/main/java/com/baidu/hugegraph/backend/store/rocksdb/RocksDBStdSessions.java
Outdated
Show resolved
Hide resolved
javeme
reviewed
Apr 29, 2022
hugegraph-rocksdb/src/main/java/com/baidu/hugegraph/backend/store/rocksdb/RocksDBOptions.java
Outdated
Show resolved
Hide resolved
...raph-rocksdb/src/main/java/com/baidu/hugegraph/backend/store/rocksdb/RocksDBStdSessions.java
Outdated
Show resolved
Hide resolved
...raph-rocksdb/src/main/java/com/baidu/hugegraph/backend/store/rocksdb/RocksDBStdSessions.java
Outdated
Show resolved
Hide resolved
align with "Maximum number..."
javeme
previously approved these changes
Apr 29, 2022
javeme
reviewed
Apr 29, 2022
...raph-rocksdb/src/main/java/com/baidu/hugegraph/backend/store/rocksdb/RocksDBStdSessions.java
Outdated
Show resolved
Hide resolved
...raph-rocksdb/src/main/java/com/baidu/hugegraph/backend/store/rocksdb/RocksDBStdSessions.java
Outdated
Show resolved
Hide resolved
seagle-yuan
reviewed
May 3, 2022
...-scylladb/src/main/java/com/baidu/hugegraph/backend/store/scylladb/ScyllaDBTablesWithMV.java
Show resolved
Hide resolved
javeme
reviewed
May 8, 2022
...-scylladb/src/main/java/com/baidu/hugegraph/backend/store/scylladb/ScyllaDBTablesWithMV.java
Outdated
Show resolved
Hide resolved
...raph-cassandra/src/main/java/com/baidu/hugegraph/backend/store/cassandra/CassandraTable.java
Show resolved
Hide resolved
javeme
approved these changes
May 10, 2022
coderzc
approved these changes
May 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix cassandra&rocksdb&scylladb code checkstyle