Skip to content

Comments

fix cassandra&rocksdb&scylladb code checkstyle#1847

Merged
javeme merged 18 commits intoapache:masterfrom
z7658329:bug/checkstyle
May 10, 2022
Merged

fix cassandra&rocksdb&scylladb code checkstyle#1847
javeme merged 18 commits intoapache:masterfrom
z7658329:bug/checkstyle

Conversation

@z7658329
Copy link
Member

@z7658329 z7658329 commented Apr 24, 2022

fix cassandra&rocksdb&scylladb code checkstyle

@codecov
Copy link

codecov bot commented Apr 24, 2022

Codecov Report

Merging #1847 (4efc58f) into master (0ed2e3b) will increase coverage by 0.26%.
The diff coverage is 73.68%.

@@             Coverage Diff              @@
##             master    #1847      +/-   ##
============================================
+ Coverage     70.70%   70.96%   +0.26%     
  Complexity      980      980              
============================================
  Files           447      447              
  Lines         38041    38076      +35     
  Branches       5389     5401      +12     
============================================
+ Hits          26897    27021     +124     
+ Misses         8508     8408     -100     
- Partials       2636     2647      +11     
Impacted Files Coverage Δ
...ugegraph/backend/store/rocksdb/RocksDBOptions.java 99.25% <ø> (ø)
...raph/backend/store/rocksdb/RocksDBStdSessions.java 76.63% <0.00%> (+0.14%) ⬆️
...hugegraph/backend/store/rocksdb/RocksDBTables.java 74.84% <33.33%> (-1.89%) ⬇️
.../backend/store/cassandra/CassandraSessionPool.java 59.00% <50.00%> (-0.60%) ⬇️
...egraph/backend/store/cassandra/CassandraTable.java 79.86% <50.00%> (ø)
...egraph/backend/store/cassandra/CassandraStore.java 74.28% <75.00%> (ø)
...egraph/backend/store/cassandra/CassandraShard.java 54.54% <100.00%> (+1.81%) ⬆️
...ugegraph/backend/store/rocksdb/RocksDBMetrics.java 85.86% <100.00%> (ø)
...gegraph/backend/store/rocksdb/RocksDBSessions.java 100.00% <100.00%> (ø)
...h/backend/store/scylladb/ScyllaDBTablesWithMV.java 96.03% <100.00%> (ø)
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ed2e3b...4efc58f. Read the comment docs.

Copy link
Contributor

@javeme javeme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still need to fix code logic changes

@z7658329 z7658329 changed the title fix rocksdb&scylladb code checkstyle fix cassandra&rocksdb&scylladb code checkstyle Apr 26, 2022
javeme
javeme previously approved these changes Apr 29, 2022
@javeme javeme merged commit f2bdedd into apache:master May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants