fix redundant Checkstyle by seagle-yuan · Pull Request #1896 · apache/hugegraph

seagle-yuan · 2022-06-05T07:49:05Z

add redundant word check

codecov · 2022-06-05T07:57:28Z

Codecov Report

Merging #1896 (868ee2f) into master (9b5950e) will increase coverage by 0.04%.
The diff coverage is 82.60%.

@@             Coverage Diff              @@
##             master    #1896      +/-   ##
============================================
+ Coverage     70.54%   70.58%   +0.04%     
+ Complexity      978      724     -254     
============================================
  Files           454      454              
  Lines         39055    39054       -1     
  Branches       5557     5557              
============================================
+ Hits          27550    27567      +17     
+ Misses         8806     8791      -15     
+ Partials       2699     2696       -3

Impacted Files	Coverage Δ
...n/java/com/baidu/hugegraph/api/auth/AccessAPI.java	`0.00% <ø> (ø)`
...ava/com/baidu/hugegraph/api/gremlin/CypherAPI.java	`0.00% <0.00%> (ø)`
...va/com/baidu/hugegraph/api/gremlin/GremlinAPI.java	`100.00% <ø> (ø)`
...a/com/baidu/hugegraph/auth/HugeGraphAuthProxy.java	`57.51% <ø> (ø)`
...aidu/hugegraph/auth/WsAndHttpBasicAuthHandler.java	`57.14% <0.00%> (ø)`
...ain/java/com/baidu/hugegraph/define/Checkable.java	`100.00% <ø> (ø)`
...ava/com/baidu/hugegraph/serializer/Serializer.java	`100.00% <ø> (ø)`
...ugegraph/backend/cache/CachedGraphTransaction.java	`85.71% <ø> (ø)`
...gegraph/backend/cache/CachedSchemaTransaction.java	`90.65% <ø> (ø)`
...va/com/baidu/hugegraph/backend/id/IdGenerator.java	`77.20% <ø> (ø)`
... and 34 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

hugegraph-api/src/main/java/com/baidu/hugegraph/auth/HugeAuthenticator.java

hugegraph-api/src/main/java/com/baidu/hugegraph/serializer/Serializer.java

hugegraph-core/src/main/java/com/baidu/hugegraph/backend/query/Aggregate.java

hugegraph-core/src/main/java/com/baidu/hugegraph/rpc/RpcServiceConfig4Server.java

hugegraph-core/src/main/java/com/baidu/hugegraph/util/RateLimiter.java

hugegraph-hbase/src/main/java/com/baidu/hugegraph/backend/store/hbase/HbaseSessions.java

hugegraph-api/src/main/java/com/baidu/hugegraph/auth/HugeAuthenticator.java

hugegraph-api/src/main/java/com/baidu/hugegraph/serializer/Serializer.java

hugegraph-core/src/main/java/com/baidu/hugegraph/backend/query/Aggregate.java

hugegraph-core/src/main/java/com/baidu/hugegraph/rpc/RpcServiceConfig4Server.java

hugegraph-core/src/main/java/com/baidu/hugegraph/traversal/algorithm/records/Records.java

hugegraph-hbase/src/main/java/com/baidu/hugegraph/backend/store/hbase/HbaseSessions.java

hugegraph-rocksdb/src/main/java/com/baidu/hugegraph/backend/store/rocksdb/RocksDBStore.java

hugegraph-hbase/src/main/java/com/baidu/hugegraph/backend/store/hbase/HbaseSessions.java

javeme · 2022-06-06T07:18:37Z

hugegraph-api/src/main/java/com/baidu/hugegraph/auth/HugeAuthenticator.java

    @Override
    default User authenticate(final Map<String, String> credentials)
-                                     throws AuthenticationException {
+            throws AuthenticationException {


align with final

I don't think so we could algin with "final"
if we break line from "credentials",we can align with "final",because "final Map<String, String> credentials" are the entire content in parenthesis
but "throws" is out of parenthesis

javeme · 2022-06-06T07:19:22Z

hugegraph-core/src/main/java/com/baidu/hugegraph/traversal/algorithm/records/Records.java


-    PathSet findPath(Id target, Function<Id, Boolean> filter,
-                            boolean all, boolean ring);
+    PathSet findPath(Id target, Function<Id, Boolean> filter, boolean all,


prefer to wrap line before "boolean all"

this line only 75 char. so i think wrap line after "boolean all" is better.

javeme · 2022-06-06T07:20:01Z

hugegraph-hbase/src/main/java/com/baidu/hugegraph/backend/store/hbase/HbaseSessions.java

         */
-        default R scan(String table, byte[] startRow,
-                              boolean inclusiveStart, byte[] prefix) {
+        default R scan(String table, byte[] startRow, boolean inclusiveStart,


prefer to wrap line before "boolean inclusiveStart"

this line only 78 char.

hugegraph-hbase/src/main/java/com/baidu/hugegraph/backend/store/hbase/HbaseSessions.java

javeme · 2022-06-06T07:26:09Z

hugegraph-hbase/src/main/java/com/baidu/hugegraph/backend/store/hbase/HbaseSessions.java

         */
-        public abstract void put(String table, byte[] family,
-                                 byte[] rowkey, byte[] qualifier, byte[] value);
+        void put(String table, byte[] family, byte[] rowkey, byte[] qualifier,


prefer to wrap line before "byte[] qualifier"

this line is only 79 char

javeme · 2022-06-06T07:26:49Z

hugegraph-hbase/src/main/java/com/baidu/hugegraph/backend/store/hbase/HbaseSessions.java

         * Get a record by rowkey and qualifier from a table
         */
-        public R get(String table, byte[] family, byte[] rowkey,
+        R get(String table, byte[] family, byte[] rowkey,


missing updating

javeme · 2022-06-06T07:30:59Z

hugegraph-hbase/src/main/java/com/baidu/hugegraph/backend/store/hbase/HbaseSessions.java

         */
-        public default void remove(String table, byte[] family,
-                                   byte[] rowkey, byte[] qualifier) {
+        default void remove(String table, byte[] family, byte[] rowkey,


prefer to wrap line before "byte[] rowkey"

this line only 72 char

…/incubator-hugegraph into checkstyle-redundant

hugegraph-hbase/src/main/java/com/baidu/hugegraph/backend/store/hbase/HbaseSessions.java

javeme · 2022-06-16T06:43:06Z

hugegraph-hbase/src/main/java/com/baidu/hugegraph/backend/store/hbase/HbaseSessions.java


        private void checkBatchResults(Object[] results, List<Row> rows)
-                                       throws Throwable {
+                throws Throwable {


…/incubator-hugegraph into checkstyle-redundant

javeme · 2022-07-06T09:09:39Z

hugegraph-hbase/src/main/java/com/baidu/hugegraph/backend/store/hbase/HbaseSessions.java

     */
    public class Session extends AbstractBackendSession
-                         implements HbaseSession<RowIterator> {
+            implements HbaseSession<RowIterator> {


can we keep the origin style: align 'implements' with 'extends'

javeme · 2022-07-06T09:10:05Z

hugegraph-api/src/main/java/com/baidu/hugegraph/auth/HugeAuthenticator.java

-    public default User authenticate(final Map<String, String> credentials)
-                                     throws AuthenticationException {
+    default User authenticate(final Map<String, String> credentials)
+            throws AuthenticationException {


can we keep the origin style: align 'throws' with 'final'

javeme · 2022-07-06T09:13:13Z

hugegraph-hbase/src/main/java/com/baidu/hugegraph/backend/store/hbase/HbaseSessions.java

                    // TODO: Mark and delete committed records
                    throw new BackendException("Failed to commit, " +
-                              "there may be inconsistent states for HBase", e);
+                                               "there may be inconsistent states for HBase", e);


exceed 100 chars?

will fixed by #1996

javeme · 2022-07-06T09:14:25Z

hugegraph-hbase/src/main/java/com/baidu/hugegraph/backend/store/hbase/HbaseSessions.java

                    byte[] val = CellUtil.cloneValue(cell);
                    LOG.info("  {}={}", StringEncoding.format(key),
-                                        StringEncoding.format(val));
+                             StringEncoding.format(val));


also wrap line before StringEncoding.format(key) for logic symmetry

javeme · 2022-07-06T09:17:15Z

style/checkstyle.xml

        </module>
        <module name="OneStatementPerLine"/>
        <module name="MultipleVariableDeclarations"/>
-        <module name="MissingSwitchDefault"/>


not sure why removed MissingSwitchDefault check

javeme · 2022-08-05T02:58:24Z

hugegraph-hbase/src/main/java/com/baidu/hugegraph/backend/store/hbase/HbaseSessions.java


        private void checkBatchResults(Object[] results, List<Row> rows)
-                                       throws Throwable {
+                throws Throwable {


can we keep the origin style: align 'throws' with 'Object[]'

javeme · 2022-08-05T02:59:24Z

please also address some other comments: https://github.com/apache/incubator-hugegraph/pull/1896/files

github-actions · 2022-09-04T21:03:44Z

Due to the lack of activity, the current pr is marked as stale and will be closed after 180 days, any update will remove the stale label

…/incubator-hugegraph into checkstyle-redundant

javeme

Looks good. there are still some tiny comments to be addressed: https://github.com/apache/incubator-hugegraph/pull/1896/files

javeme · 2022-10-30T12:07:51Z

Looks good. there are still some tiny comments to be addressed: https://github.com/apache/incubator-hugegraph/pull/1896/files

will fixed by #1996

seagle-yuan added 3 commits June 3, 2022 15:26

add redundant

163df9f

Merge branch 'master' into checkstyle-redundant

db21536

add redundant check

02f0207

seagle-yuan changed the title ~~Checkstyle redundant~~ fix redundant Checkstyle Jun 5, 2022

javeme reviewed Jun 5, 2022

View reviewed changes

merge line

bfdf11a

seagle-yuan requested a review from javeme June 6, 2022 04:51

javeme reviewed Jun 6, 2022

View reviewed changes

update alignment

12b91c1

seagle-yuan requested a review from javeme June 6, 2022 06:33

javeme reviewed Jun 6, 2022

View reviewed changes

seagle-yuan and others added 5 commits June 13, 2022 14:22

Merge branch 'master' into checkstyle-redundant

2de645d

delete duplicates check MissingSwitchDefault

92a4bf0

Merge branch 'apache:master' into checkstyle-redundant

f437554

Merge branch 'checkstyle-redundant' of https://github.com/seagle-yuan…

f6240a5

…/incubator-hugegraph into checkstyle-redundant

update wrap line

d3d7c79

seagle-yuan requested a review from javeme June 15, 2022 13:43

javeme reviewed Jun 16, 2022

View reviewed changes

seagle-yuan and others added 4 commits June 17, 2022 09:40

update code style

ff82af0

Merge branch 'master' into checkstyle-redundant

432cc04

Merge branch 'apache:master' into checkstyle-redundant

74193f2

Merge branch 'checkstyle-redundant' of https://github.com/seagle-yuan…

f96a617

…/incubator-hugegraph into checkstyle-redundant

javeme reviewed Jul 6, 2022

View reviewed changes

seagle-yuan and others added 2 commits August 3, 2022 11:00

Merge branch 'apache:master' into checkstyle-redundant

765bd85

Merge branch 'master' into checkstyle-redundant

1447e1e

javeme reviewed Aug 5, 2022

View reviewed changes

github-actions bot added the inactive label Sep 4, 2022

seagle-yuan added 4 commits September 9, 2022 20:48

Merge branch 'checkstyle-redundant' of https://github.com/seagle-yuan…

341a18a

…/incubator-hugegraph into checkstyle-redundant

merge dev

c1e2d4c

merge master

6ab5ab6

merge master

8cda2a0

javeme approved these changes Oct 13, 2022

View reviewed changes

Merge branch 'apache:master' into checkstyle-redundant

868ee2f

corgiboygsj approved these changes Oct 26, 2022

View reviewed changes

zyxxoo merged commit cc80d27 into apache:master Oct 30, 2022

seagle-yuan deleted the checkstyle-redundant branch November 28, 2022 10:07

Comments

Conversation

seagle-yuan commented Jun 5, 2022

Uh oh!

codecov bot commented Jun 5, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

seagle-yuan Jun 15, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

zyxxoo Oct 30, 2022 • edited by javeme Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

codecov bot commented Jun 5, 2022 •

edited

Loading

seagle-yuan Jun 15, 2022 •

edited

Loading

zyxxoo Oct 30, 2022 •

edited by javeme

Loading

javeme left a comment •

edited

Loading