Conversation
Codecov Report
@@ Coverage Diff @@
## master #2024 +/- ##
============================================
- Coverage 64.38% 58.88% -5.51%
Complexity 978 978
============================================
Files 482 482
Lines 41463 41463
Branches 5890 5890
============================================
- Hits 26698 24414 -2284
- Misses 12122 14616 +2494
+ Partials 2643 2433 -210
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| # Variables | ||
| INSTALL_DIR= |
There was a problem hiding this comment.
change the comment, it requires user to set a fixed abs path manually (should't use a relative path)
There was a problem hiding this comment.
You are right. and I think should add check for Variables
| ### END INIT INFO | ||
|
|
||
| # Variables | ||
| # it requires user to set a fixed abs path manually |
There was a problem hiding this comment.
we can try ${INSTALL_DIR:?"Please setting variables 'INSTALL_DIR'"}
for more details: https://stackoverflow.com/a/16753536
There was a problem hiding this comment.
@javeme seems a little strange, could it use directly or test it in local evn? (or should in a if condition?)
failed with all cases in my ubuntu21
| INSTALL_DIR= | ||
| SERVER_PORT= | ||
|
|
||
| ${INSTALL_DIR:?"Please setting variables 'INSTALL_DIR'"} |
There was a problem hiding this comment.
😺, nice
typo `setting --> set``
imbajin
left a comment
There was a problem hiding this comment.
I'll enhance this script later


Motivation
Run
bin/hugegraph starterrorModifications
Add check for
Variables