add github token for license check comment#2139
Merged
javeme merged 1 commit intoapache:masterfrom Mar 2, 2023
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2139 +/- ##
=============================================
- Coverage 66.57% 53.44% -13.13%
+ Complexity 979 652 -327
=============================================
Files 481 481
Lines 39704 39704
Branches 5581 5581
=============================================
- Hits 26432 21220 -5212
- Misses 10687 16238 +5551
+ Partials 2585 2246 -339
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
imbajin
reviewed
Mar 2, 2023
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| with: | ||
| log: info | ||
| token: ${{ github.token }} |
Member
There was a problem hiding this comment.
Good, but how does it take effect in #2130? (related to the submit person?)
imbajin
approved these changes
Mar 2, 2023
javeme
approved these changes
Mar 2, 2023
Member
|
@JackyYangPassion seems the problem still exist after this PR merged, and found another problem (validation not right) 1. we shouldn't allow
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



the token that license eye uses when it needs to comment on the pull request. Set to empty ("") to disable commenting on pull request. The default value is ${{ github.token }}