Skip to content

add github token for license check comment#2139

Merged
javeme merged 1 commit intoapache:masterfrom
JackyYangPassion:fix-license-ci
Mar 2, 2023
Merged

add github token for license check comment#2139
javeme merged 1 commit intoapache:masterfrom
JackyYangPassion:fix-license-ci

Conversation

@JackyYangPassion
Copy link
Contributor

the token that license eye uses when it needs to comment on the pull request. Set to empty ("") to disable commenting on pull request. The default value is ${{ github.token }}

@codecov
Copy link

codecov bot commented Mar 1, 2023

Codecov Report

Merging #2139 (ec03b03) into master (1d52476) will decrease coverage by 13.13%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             master    #2139       +/-   ##
=============================================
- Coverage     66.57%   53.44%   -13.13%     
+ Complexity      979      652      -327     
=============================================
  Files           481      481               
  Lines         39704    39704               
  Branches       5581     5581               
=============================================
- Hits          26432    21220     -5212     
- Misses        10687    16238     +5551     
+ Partials       2585     2246      -339     
Impacted Files Coverage Δ
...he/hugegraph/util/FixedWatchWindowRateLimiter.java 0.00% <0.00%> (-100.00%) ⬇️
...hugegraph/backend/store/raft/RaftStoreClosure.java 0.00% <0.00%> (-100.00%) ⬇️
...hugegraph/job/schema/OlapPropertyKeyCreateJob.java 0.00% <0.00%> (-100.00%) ⬇️
...hugegraph/job/schema/OlapPropertyKeyRemoveJob.java 0.00% <0.00%> (-100.00%) ⬇️
...ugegraph/backend/store/memory/InMemoryMetrics.java 0.00% <0.00%> (-100.00%) ⬇️
...egraph/backend/store/scylladb/ScyllaDBMetrics.java 0.00% <0.00%> (-100.00%) ⬇️
...graph/backend/store/scylladb/ScyllaDBFeatures.java 0.00% <0.00%> (-100.00%) ⬇️
...ackend/store/cassandra/CassandraStoreProvider.java 0.00% <0.00%> (-100.00%) ⬇️
.../hugegraph/backend/store/raft/StoreSerializer.java 0.00% <0.00%> (-98.42%) ⬇️
.../backend/store/scylladb/ScyllaDBStoreProvider.java 0.00% <0.00%> (-96.16%) ⬇️
... and 163 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with:
log: info
token: ${{ github.token }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, but how does it take effect in #2130? (related to the submit person?)

@javeme javeme merged commit 76fa644 into apache:master Mar 2, 2023
@imbajin
Copy link
Member

imbajin commented Mar 3, 2023

@JackyYangPassion seems the problem still exist after this PR merged, and found another problem (validation not right)

1. we shouldn't allow Copyright appear in the header

refer here:
image

So as other invalid/extra words, it should alert error

2. lack of the header

now we have the github.token in it, however it also failed to comment, and follow the previous comments question, seems something we should still dig it out

image

image

refer:

  1. current action url
  2. person PR without token but with comments (lack write permission?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants