Skip to content

fix exception of vertex-drop with index#2181

Merged
javeme merged 2 commits intoapache:masterfrom
simon824:fix2062
Mar 29, 2023
Merged

fix exception of vertex-drop with index#2181
javeme merged 2 commits intoapache:masterfrom
simon824:fix2062

Conversation

@simon824
Copy link
Member

@simon824 simon824 commented Mar 28, 2023

closed #2062

According to @javeme 's solution (#2062 (comment)), the id will be filtered during querying vertices and properties will still be null(refer to the screenshot below).

image

And it works if force loading properties (forceLoad) before vertex being added to removedVertices in GraphTransaction.removeVertex().

@simon824 simon824 requested a review from javeme March 28, 2023 03:41
@codecov
Copy link

codecov bot commented Mar 28, 2023

Codecov Report

Merging #2181 (a99691d) into master (6997a87) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             master    #2181    +/-   ##
==========================================
  Coverage     65.08%   65.08%            
- Complexity      676      977   +301     
==========================================
  Files           497      497            
  Lines         40564    40566     +2     
  Branches       5662     5663     +1     
==========================================
+ Hits          26400    26402     +2     
- Misses        11549    11551     +2     
+ Partials       2615     2613     -2     
Impacted Files Coverage Δ
.../apache/hugegraph/backend/tx/GraphTransaction.java 79.95% <100.00%> (+0.04%) ⬆️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

imbajin
imbajin previously approved these changes Mar 28, 2023
Copy link
Member

@imbajin imbajin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the context

@javeme javeme changed the title fix drop vertex exception fix exception of vertex-drop with index Mar 29, 2023
@javeme javeme merged commit 7b6a4bd into apache:master Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] drop报错 Non-null property 'xxx' is null for xxx

3 participants