Skip to content

doc: modify ASF and remove meaningless CLA#2237

Merged
javeme merged 4 commits intoapache:masterfrom
KeeProMise:ASF_CLA
Jul 1, 2023
Merged

doc: modify ASF and remove meaningless CLA#2237
javeme merged 4 commits intoapache:masterfrom
KeeProMise:ASF_CLA

Conversation

@KeeProMise
Copy link
Member

1.Discussion is also split into discussion_status and discussion_comment, the former sends dev and the latter sends issues, so as to avoid the disturbance of a dev email for each comment and affect the effectiveness of everyone's subscription.
2.There is an obsolete and unnecessary CLA signature in our contribution doc, just remove it

Copy link
Member

@imbajin imbajin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Jun 30, 2023

Codecov Report

Merging #2237 (5a4f1d1) into master (5227248) will decrease coverage by 4.14%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #2237      +/-   ##
============================================
- Coverage     68.52%   64.39%   -4.14%     
+ Complexity      977      676     -301     
============================================
  Files           498      498              
  Lines         40682    40682              
  Branches       5681     5681              
============================================
- Hits          27879    26197    -1682     
- Misses        10097    11859    +1762     
+ Partials       2706     2626      -80     

see 79 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@imbajin imbajin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sync 3rd party doc section from website

@KeeProMise
Copy link
Member Author

sync 3rd party doc section from website

I have submitted the newly added documents to my warehouse yesterday, why is the pr not updated here?
https://github.com/KeeProMise/incubator-hugegraph/tree/ASF_CLA

@KeeProMise
Copy link
Member Author

sync 3rd party doc section from website

KeeProMise@c7a869a

@imbajin
Copy link
Member

imbajin commented Jul 1, 2023

sync 3rd party doc section from website

I have submitted the newly added documents to my warehouse yesterday, why is the pr not updated here?
https://github.com/KeeProMise/incubator-hugegraph/tree/ASF_CLA

try to submit an empty commit?
(or ask gpt)

@KeeProMise
Copy link
Member Author

sync 3rd party doc section from website

I have submitted the newly added documents to my warehouse yesterday, why is the pr not updated here?
https://github.com/KeeProMise/incubator-hugegraph/tree/ASF_CLA

try to submit an empty commit? (or ask gpt)

should be ok

Copy link
Contributor

@javeme javeme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@javeme javeme merged commit 8ee3d32 into apache:master Jul 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants