Skip to content

Comments

fix(core): task restore interrupt problem on restart server#2401

Merged
imbajin merged 3 commits intoapache:masterfrom
xiaoleizi2016:issue_2389
Dec 29, 2023
Merged

fix(core): task restore interrupt problem on restart server#2401
imbajin merged 3 commits intoapache:masterfrom
xiaoleizi2016:issue_2389

Conversation

@xiaoleizi2016
Copy link
Contributor

@xiaoleizi2016 xiaoleizi2016 commented Dec 24, 2023

Purpose of the PR

Main Changes

Verifying these changes

  • Trivial rework / code cleanup without any test coverage. (No Need)
  • Already covered by existing tests, such as (please modify tests here).
  • Need tests and can be verified as follows:
    • xxx

Does this PR potentially affect the following parts?

  • Nope
  • Dependencies (add/update license info)
  • Modify configurations
  • The public API
  • Other affects (typed here)

Documentation Status

  • Doc - TODO
  • Doc - Done
  • Doc - No Need

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Dec 24, 2023
@codecov
Copy link

codecov bot commented Dec 24, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (7635c67) 65.59% compared to head (499e8f1) 66.23%.

Files Patch % Lines
...g/apache/hugegraph/task/StandardTaskScheduler.java 16.66% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2401      +/-   ##
============================================
+ Coverage     65.59%   66.23%   +0.64%     
- Complexity      587      828     +241     
============================================
  Files           511      511              
  Lines         42590    42595       +5     
  Branches       5941     5942       +1     
============================================
+ Hits          27936    28213     +277     
+ Misses        11840    11562     -278     
- Partials       2814     2820       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@imbajin imbajin changed the title 修复系统启动时,任务恢复调度时,任务判重冲突导致启动中断的问题,对应的issue #2389 fix(core): task restore interrupt problem on restart server Dec 24, 2023
@imbajin imbajin requested review from javeme and zyxxoo December 24, 2023 04:10
} while (page != null);
}
for (HugeTask<V> task : taskList){
LOG.info("restore task {}",task );
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

expect the space after ","

HugeTask<V> task = iter.next();
if (selfServer.equals(task.server())) {
this.restore(task);
taskList.add(task);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we may fix this bug by changing the order of PENDING_STATUSES elements

Copy link
Contributor

@javeme javeme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imbajin imbajin merged commit cf9ba8b into apache:master Dec 29, 2023
VGalaxies pushed a commit to VGalaxies/incubator-hugegraph that referenced this pull request Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] hugegraph任务调度机制

3 participants