fix(server): make CacheManager constructor private to satisfy the singleton pattern#2432
Merged
VGalaxies merged 2 commits intoapache:masterfrom Feb 1, 2024
Merged
fix(server): make CacheManager constructor private to satisfy the singleton pattern#2432VGalaxies merged 2 commits intoapache:masterfrom
VGalaxies merged 2 commits intoapache:masterfrom
Conversation
dosubot
bot
added
size:XS
Contributor
Author
|
PTAL~ @imbajin @VGalaxies |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2432 +/- ##
============================================
- Coverage 66.23% 66.20% -0.04%
Complexity 828 828
============================================
Files 511 511
Lines 42597 42597
Branches 5942 5942
============================================
- Hits 28215 28202 -13
- Misses 11566 11584 +18
+ Partials 2816 2811 -5 ☔ View full report in Codecov by Sentry. |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
imbajin
approved these changes
Jan 30, 2024
imbajin
changed the title
VGalaxies
pushed a commit
that referenced
this pull request
Feb 3, 2024
VGalaxies
pushed a commit
that referenced
this pull request
Feb 3, 2024
msgui
pushed a commit
to msgui/incubator-hugegraph
that referenced
this pull request
Feb 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the sake of regulation and safety, we should privatize the constructor of cacheManager to satisfy the singleton pattern