fix(server): unify the license headers

[msgui]

Purpose of the PR

• subtask of [Summary] Enhance code style warnings in server #2435

Main Changes

Verifying these changes

• Trivial rework / code cleanup without any test coverage. (No Need)
• Already covered by existing tests, such as (please modify tests here).
• Need tests and can be verified as follows:
  • xxx

Does this PR potentially affect the following parts?

• Nope
• Dependencies (add/update license info)
• Modify configurations
• The public API
• Other affects (typed here)

Documentation Status

• Doc - TODO
• Doc - Done
• Doc - No Need

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1d4532c) 66.23% compared to head (9ed3749) 61.39%.
Report is 1 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff              @@
##             master    #2438      +/-   ##
============================================
- Coverage     66.23%   61.39%   -4.84%     
+ Complexity      828      488     -340     
============================================
  Files           511      511              
  Lines         42597    42598       +1     
  Branches       5942     5942              
============================================
- Hits          28215    26154    -2061     
- Misses        11566    13759    +2193     
+ Partials       2816     2685     -131     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[imbajin]

fine, wonder to know all the files header are updated?

[msgui]

fine, wonder to know all the files header are updated?

This PR solely updates the license header in hg-server/hg-api.

[imbajin]

fine, wonder to know all the files header are updated?

This PR solely updates the license header in hg-server/hg-api.

Get it, license header could update together (due to it is almost a completely repetitive task, just take a few samples for inspection and confirmation, no need to check them one by one)

[VGalaxies]

@msgui I noticed that some configuration files, such as hugegraph-server/hugegraph-test/src/main/resources/hugegraph.properties, do not have corresponding modified license headers. Is this expected?

[msgui]

@msgui I noticed that some configuration files, such as hugegraph-server/hugegraph-test/src/main/resources/hugegraph.properties, do not have corresponding modified license headers. Is this expected?

thanks for the reminder

[msgui]

this commit includes files of all formats for easy review.

👉:47e2fe24976efe092fd6f944444be00ba142cba5

[VGalaxies]

PTAL~

1. It seems reasonable to consider updating the license header for the entire repository, not just under hugegraph-server.
2. For the license headers only under hugegraph-server, there still seem to be some missed files. I have conducted a preliminary count (just a reminder):
   
   (expected: 791, actual: 783)

[VGalaxies]

Also, these extra blank lines here can be removed, it seems?

(compared to https://github.com/apache/incubator-hugegraph/wiki/HugeGraph-Code-Style-Guide)

[msgui]

PTAL~

1. It seems reasonable to consider updating the license header for the entire repository, not just under hugegraph-server.
2. For the license headers only under hugegraph-server, there still seem to be some missed files. I have conducted a preliminary count (just a reminder):
   
   (expected: 791, actual: 783)

Thank you for the reminder. The license header format in the remaining files is already correct, so no further corrections are needed

eg: hugegraph-server/Dockerfile

[VGalaxies]

Great work! I have performed verification locally following the steps in Project Migration/Package Name Change + IDEA Configuration Instructions (Complete Version), and it meets expectations.

@msgui Consider supplementing the detailed steps for updating copyright to the above document, explaining how to configure IDEA from scratch and how to update copyright with a single click (Because I encountered some unclear points during the configuration process, such as how to match the files that need updating, the relevant content in the above document is somewhat scattered. It might be beneficial to consolidate it together)

[VGalaxies]

@imbajin could also check again~

Additionally, I believe that performing the license header check in the current CI (licence-checker.yml) seems somewhat delayed. It might be worth considering moving it to the verify stage. This way, developers can discover related errors earlier during local builds.

[imbajin]

@imbajin could also check again~

Additionally, I believe that performing the license header check in the current CI (licence-checker.yml) seems somewhat delayed. It might be worth considering moving it to the verify stage. This way, developers can discover related errors earlier during local builds.

Good suggestion, could mark it as a TODO (enhance our CI to check/validate style problems)

[liuxiaocs7]

This tool hawkeye may help license header check and format?

[imbajin]

TODOs:

• keep the LICENSE header from refer code (revert/exclude it by reg?)
• rearrange the commit range
• keep the dist/*/bin/*.properties (user config files) clean (no need to add header here)
• remove the header in org.apache.tinkerpop.gremlin.server.OpProcessor or GremlinPlugin (pure text file)

[VGalaxies]

It seems that some files license headers are inconsistent with those in https://github.com/apache/incubator-hugegraph/wiki/HugeGraph-Code-Style-Guide.

TODOs:

• keep the LICENSE header from refer code (revert/exclude it by reg?)
• rearrange the commit range
• keep the dist/*/bin/*.properties (user config files) clean (no need to add header here)
• remove the header in org.apache.tinkerpop.gremlin.server.OpProcessor or GremlinPlugin (pure text file)

Also, do the TODOs here need to be addressed in this PR? @imbajin

[imbajin]

Almost have checked all the files already (Also finished all the TODOS now)

[VGalaxies]

LGTM~

[VGalaxies]

• keep the dist/*/bin/*.properties (user config files) clean (no need to add header here)

@imbajin Is it only for cleaning the license header in properties files in user configuration files here? I found that some other user configuration files have license headers.

Also, do properties files in the conf-raft* directory need to have their license headers cleaned?

[imbajin]

• keep the dist/*/bin/*.properties (user config files) clean (no need to add header here)

@imbajin Is it only for cleaning the license header in properties files in user configuration files here? I found that some other user configuration files have license headers.

@VGalaxies
The current judgment points are:

1. If a configuration file is not frequently used/modified by users, following ASF's suggestion may be better to add a file header to reduce disputes
2. Otherwise(In HG), considering that there are already many configuration files and the content is relatively long, the commonly used configurations by users are not separately added to avoid affecting the user experience
3. (like point 1) Configuration files from testing/and other modules could also add headers (although not required)

Also, do properties files in the conf-raft* directory need to have their license headers cleaned?

So these places seem to fit the 1st & 3rd points and can preserve license headers.