Skip to content

Comments

refact: enhance cache invalidation of the partition -> leader shard in ClientCache#2588

Merged
VGalaxies merged 1 commit intoapache:masterfrom
haohao0103:alan-master-dev3
Jul 15, 2024
Merged

refact: enhance cache invalidation of the partition -> leader shard in ClientCache#2588
VGalaxies merged 1 commit intoapache:masterfrom
haohao0103:alan-master-dev3

Conversation

@haohao0103
Copy link
Contributor

Resolved the cache invalidation of the partition->leader shard in ClientCache

Purpose of the PR
close #2576

Main Changes
1、Set the initialization flag to false after resetting the cache, allowing reinitialization;
2、If the cache misses, the cache is updated with the results of the query from the PD.

Resolve the cache invalidation of the partition->leader shard in ClientCache
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. pd PD module labels Jul 15, 2024
@codecov
Copy link

codecov bot commented Jul 15, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 4.54%. Comparing base (03b40a5) to head (2e77882).
Report is 2 commits behind head on master.

Files Patch % Lines
...va/org/apache/hugegraph/pd/client/ClientCache.java 0.00% 1 Missing ⚠️
.../java/org/apache/hugegraph/pd/client/PDClient.java 50.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (03b40a5) and HEAD (2e77882). Click for more details.

HEAD has 5 uploads less than BASE
Flag BASE (03b40a5) HEAD (2e77882)
6 1
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #2588       +/-   ##
============================================
- Coverage     52.49%   4.54%   -47.95%     
+ Complexity      586     479      -107     
============================================
  Files           643     621       -22     
  Lines         53393   50877     -2516     
  Branches       7018    6570      -448     
============================================
- Hits          28026    2312    -25714     
- Misses        22538   48379    +25841     
+ Partials       2829     186     -2643     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@imbajin imbajin changed the title Resolve the cache invalidation of the partition->leader shard in ClientCache refact: enhance cache invalidation of the partition->leader shard in ClientCache Jul 15, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 15, 2024
@VGalaxies VGalaxies changed the title refact: enhance cache invalidation of the partition->leader shard in ClientCache refact: enhance cache invalidation of the partition -> leader shard in ClientCache Jul 15, 2024
@VGalaxies VGalaxies merged commit 85e0966 into apache:master Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer pd PD module size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

[Bug] Resolved the cache invalidation of the partition->leader shard in ClientCache

3 participants