refact: enhance cache invalidation of the partition -> leader shard in ClientCache#2588
Merged
VGalaxies merged 1 commit intoapache:masterfrom Jul 15, 2024
Merged
Conversation
Resolve the cache invalidation of the partition->leader shard in ClientCache
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2588 +/- ##
============================================
- Coverage 52.49% 4.54% -47.95%
+ Complexity 586 479 -107
============================================
Files 643 621 -22
Lines 53393 50877 -2516
Branches 7018 6570 -448
============================================
- Hits 28026 2312 -25714
- Misses 22538 48379 +25841
+ Partials 2829 186 -2643 ☔ View full report in Codecov by Sentry. |
JackyYangPassion
approved these changes
Jul 15, 2024
VGalaxies
approved these changes
Jul 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolved the cache invalidation of the partition->leader shard in ClientCache
Purpose of the PR
close #2576
Main Changes
1、Set the initialization flag to false after resetting the cache, allowing reinitialization;
2、If the cache misses, the cache is updated with the results of the query from the PD.