chore: fix lombok compiling error and error for list cast to string#2592
chore: fix lombok compiling error and error for list cast to string#2592
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2592 +/- ##
============================================
+ Coverage 47.56% 47.64% +0.08%
Complexity 820 820
============================================
Files 718 718
Lines 58490 58490
Branches 7496 7496
============================================
+ Hits 27821 27870 +49
+ Misses 27889 27832 -57
- Partials 2780 2788 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
hugegraph-pd/hg-pd-client/pom.xml
Outdated
| <groupId>org.projectlombok</groupId> | ||
| <artifactId>lombok</artifactId> | ||
| <version>1.18.20</version> | ||
| <version>1.18.30</version> |
There was a problem hiding this comment.
Shall we use a unified version property for it?
hugegraph-pd/hg-pd-client/pom.xml
Outdated
| <groupId>org.projectlombok</groupId> | ||
| <artifactId>lombok</artifactId> | ||
| <version>1.18.20</version> | ||
| <version>1.18.30</version> |
There was a problem hiding this comment.
Can we remove the lombok dependency:
since we don't have a large places to generate/replace code, and in the few places where it's necessary, I would rather write some code manually to maintain a consistent style.
|
@zyxxoo The version also needs to be bumped in hg-pd-common. |
c2dc5a7 to
c33376f
Compare
hugegraph-commons/pom.xml
Outdated
| <dependency> | ||
| <groupId>org.projectlombok</groupId> | ||
| <artifactId>lombok</artifactId> | ||
| <version>1.18.30</version> |
There was a problem hiding this comment.
Maybe we could add <optional>true</optional> and provide scope for it?
There was a problem hiding this comment.
the optional mean don't transfer dependency, for example, A -> B -> C, if B. use. optional true to c, the A will not reference C
so the optional in our code maybe don't importament
hugegraph-store/pom.xml
Outdated
| <dependency> | ||
| <groupId>org.projectlombok</groupId> | ||
| <artifactId>lombok</artifactId> | ||
| <version>1.18.30</version> |
There was a problem hiding this comment.
no, the code is in dependencymanager
|
TODO: |
imbajin
left a comment
There was a problem hiding this comment.
TODO: replace each 3rd-level-module deps by 2nd-level-module dep
fix Fatal error compiling:
java.lang.NoSuchFieldError: Class com.sun.tools.javac.tree.JCTree$JCImport does not have member field 'com.sun.tools.javac.tree.JCTree qualid'